Skip to content

Conversation

dianqk
Copy link
Member

@dianqk dianqk commented Jul 17, 2025

@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@cuviper
Copy link
Member

cuviper commented Jul 17, 2025

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Jul 17, 2025

📌 Commit 16d8f3c has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2025
@bors
Copy link
Collaborator

bors commented Jul 20, 2025

⌛ Testing commit 16d8f3c with merge 81af9d4...

@bors
Copy link
Collaborator

bors commented Jul 20, 2025

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 81af9d4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 20, 2025
@bors bors merged commit 81af9d4 into rust-lang:master Jul 20, 2025
12 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 20, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6707bf0 (parent) -> 81af9d4 (this PR)

Test differences

Show 1 test diff

Stage 2

  • [run-make] tests/run-make/compressed-debuginfo-zstd: pass -> ignore (ignored if LLVM wasn't build with zstd for ELF section compression (we want LLVM/LLD to be built with zstd support)) (J0)

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 81af9d45698a19183b8552079cbc7bf893fad1e5 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-apple: 8332.5s -> 11338.7s (36.1%)
  2. pr-check-1: 1696.7s -> 2119.4s (24.9%)
  3. tidy: 69.4s -> 53.9s (-22.2%)
  4. x86_64-rust-for-linux: 2936.6s -> 3449.4s (17.5%)
  5. x86_64-gnu-miri: 4797.7s -> 5623.3s (17.2%)
  6. x86_64-gnu-tools: 3699.9s -> 4319.3s (16.7%)
  7. test-various: 4883.9s -> 5696.8s (16.6%)
  8. pr-check-2: 3276.3s -> 2734.6s (-16.5%)
  9. x86_64-apple-1: 9374.9s -> 7837.0s (-16.4%)
  10. dist-x86_64-solaris: 6080.1s -> 5225.1s (-14.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@bors bors mentioned this pull request Jul 20, 2025
8 tasks
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (81af9d4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.7%, secondary -4.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.7% [2.7%, 2.7%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.2% [-4.2%, -4.2%] 1
All ❌✅ (primary) 2.7% [2.7%, 2.7%] 1

Cycles

Results (secondary 2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 465.018s -> 465.3s (0.06%)
Artifact size: 374.58 MiB -> 374.58 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants