Skip to content

Conversation

CaiWeiran
Copy link

The test tests/run-make/link-eh-frame-terminator/rmake.rs fails to link when cross-compiling. Therefore, it should be ignored in cross-compilation environments.
See commit a27bdea and commit 2beccc4 for reference.

@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2025

This PR modifies run-make tests.

cc @jieyouxu

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 18, 2025

📌 Commit d5411f7 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2025
bors added a commit that referenced this pull request Jul 19, 2025
Rollup of 10 pull requests

Successful merges:

 - #141076 (fix Zip unsoundness (again))
 - #142444 (adding run-make test to autodiff)
 - #143704 (Be a bit more careful around exotic cycles in in the inliner)
 - #144073 (Don't test panic=unwind in panic_main.rs on Fuchsia)
 - #144083 (miri sleep tests: increase slack)
 - #144092 (bootstrap: Detect musl hosts)
 - #144098 (Do not lint private-in-public for RPITIT)
 - #144103 (Rename `emit_unless` to `emit_unless_delay`)
 - #144108 (Ignore tests/run-make/link-eh-frame-terminator/rmake.rs when cross-compiling)
 - #144115 (fix outdated comment)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ae77628 into rust-lang:master Jul 19, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 19, 2025
rust-timer added a commit that referenced this pull request Jul 19, 2025
Rollup merge of #144108 - CaiWeiran:run-make_test, r=jieyouxu

Ignore tests/run-make/link-eh-frame-terminator/rmake.rs when cross-compiling

The test tests/run-make/link-eh-frame-terminator/rmake.rs fails to link when cross-compiling. Therefore, it should be ignored in cross-compilation environments.
See [commit a27bdea](a27bdea) and [commit 2beccc4](2beccc4) for reference.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jul 20, 2025
Rollup of 10 pull requests

Successful merges:

 - rust-lang/rust#141076 (fix Zip unsoundness (again))
 - rust-lang/rust#142444 (adding run-make test to autodiff)
 - rust-lang/rust#143704 (Be a bit more careful around exotic cycles in in the inliner)
 - rust-lang/rust#144073 (Don't test panic=unwind in panic_main.rs on Fuchsia)
 - rust-lang/rust#144083 (miri sleep tests: increase slack)
 - rust-lang/rust#144092 (bootstrap: Detect musl hosts)
 - rust-lang/rust#144098 (Do not lint private-in-public for RPITIT)
 - rust-lang/rust#144103 (Rename `emit_unless` to `emit_unless_delay`)
 - rust-lang/rust#144108 (Ignore tests/run-make/link-eh-frame-terminator/rmake.rs when cross-compiling)
 - rust-lang/rust#144115 (fix outdated comment)

r? `@ghost`
`@rustbot` modify labels: rollup
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
Ignore tests/run-make/link-eh-frame-terminator/rmake.rs when cross-compiling

The test tests/run-make/link-eh-frame-terminator/rmake.rs fails to link when cross-compiling. Therefore, it should be ignored in cross-compilation environments.
See [commit a27bdea](rust-lang@a27bdea) and [commit 2beccc4](rust-lang@2beccc4) for reference.
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#141076 (fix Zip unsoundness (again))
 - rust-lang#142444 (adding run-make test to autodiff)
 - rust-lang#143704 (Be a bit more careful around exotic cycles in in the inliner)
 - rust-lang#144073 (Don't test panic=unwind in panic_main.rs on Fuchsia)
 - rust-lang#144083 (miri sleep tests: increase slack)
 - rust-lang#144092 (bootstrap: Detect musl hosts)
 - rust-lang#144098 (Do not lint private-in-public for RPITIT)
 - rust-lang#144103 (Rename `emit_unless` to `emit_unless_delay`)
 - rust-lang#144108 (Ignore tests/run-make/link-eh-frame-terminator/rmake.rs when cross-compiling)
 - rust-lang#144115 (fix outdated comment)

r? `@ghost`
`@rustbot` modify labels: rollup
@CaiWeiran CaiWeiran deleted the run-make_test branch July 28, 2025 06:47
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jul 29, 2025
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#141076 (fix Zip unsoundness (again))
 - rust-lang#142444 (adding run-make test to autodiff)
 - rust-lang#143704 (Be a bit more careful around exotic cycles in in the inliner)
 - rust-lang#144073 (Don't test panic=unwind in panic_main.rs on Fuchsia)
 - rust-lang#144083 (miri sleep tests: increase slack)
 - rust-lang#144092 (bootstrap: Detect musl hosts)
 - rust-lang#144098 (Do not lint private-in-public for RPITIT)
 - rust-lang#144103 (Rename `emit_unless` to `emit_unless_delay`)
 - rust-lang#144108 (Ignore tests/run-make/link-eh-frame-terminator/rmake.rs when cross-compiling)
 - rust-lang#144115 (fix outdated comment)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants