Skip to content

Add release notes for 1.89.0 #144509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 6, 2025
Merged

Add release notes for 1.89.0 #144509

merged 4 commits into from
Aug 6, 2025

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jul 26, 2025

r? @BoxyUwU
cc @rust-lang/release
@rustbot ping relnotes-interest-group

@rustbot
Copy link
Collaborator

rustbot commented Jul 26, 2025

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Jul 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 26, 2025

Hi relnotes-interest-group, this issue/PR could use some help in reviewing /
adjusting release notes. Could you take a look if available? Thanks <3

cc @alex-semenyuk @jieyouxu @joshtriplett @Kobzol @lcnr @traviscross

BoxyUwU and others added 2 commits August 4, 2025 10:28
Co-authored-by: alexey semenyuk <[email protected]>
Co-authored-by: alexey semenyuk <[email protected]>
@BoxyUwU
Copy link
Member

BoxyUwU commented Aug 6, 2025

@bors r+ rollup p=1

release is tomorrow want this merged quickly :>

@bors
Copy link
Collaborator

bors commented Aug 6, 2025

📌 Commit 607133b has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2025
@bors
Copy link
Collaborator

bors commented Aug 6, 2025

⌛ Testing commit 607133b with merge 7d82b83...

@bors
Copy link
Collaborator

bors commented Aug 6, 2025

☀️ Test successful - checks-actions
Approved by: BoxyUwU
Pushing 7d82b83 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 6, 2025
@bors bors merged commit 7d82b83 into rust-lang:master Aug 6, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 6, 2025
Copy link
Contributor

github-actions bot commented Aug 6, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 29cdc6a (parent) -> 7d82b83 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 7d82b83ed57d188ab3f2441a765a6419685a88a3 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 5151.5s -> 8082.6s (56.9%)
  2. x86_64-apple-2: 6978.1s -> 3895.0s (-44.2%)
  3. x86_64-apple-1: 9944.3s -> 6707.0s (-32.6%)
  4. dist-x86_64-apple: 10745.2s -> 13308.5s (23.9%)
  5. dist-s390x-linux: 5432.5s -> 4916.4s (-9.5%)
  6. dist-powerpc-linux: 5490.1s -> 4997.1s (-9.0%)
  7. aarch64-msvc-1: 7024.1s -> 6427.1s (-8.5%)
  8. dist-arm-linux-gnueabi: 5195.1s -> 4777.3s (-8.0%)
  9. dist-x86_64-netbsd: 5177.3s -> 4826.6s (-6.8%)
  10. x86_64-gnu-miri: 4945.7s -> 4615.9s (-6.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7d82b83): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.6% [0.5%, 0.6%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -5.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-5.9% [-7.2%, -4.6%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -5.9% [-7.2%, -4.6%] 2

Cycles

Results (primary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.5% [-2.5%, -2.5%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.5% [-2.5%, -2.5%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 464.98s -> 463.234s (-0.38%)
Artifact size: 377.39 MiB -> 377.36 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants