fix MIPS target #14455
Closed
fix MIPS target #14455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -270,7 +270,7 @@ fn initialize_call_frame(regs: &mut Registers, fptr: InitFn, arg: uint, | |||
| type Registers = [uint, ..32]; | |||
|
|
|||
| #[cfg(target_arch = "mips")] | |||
| fn new_regs() -> Box<Registers> { box [0, .. 32] } | |||
| fn new_regs() -> Box<Registers> { box {[0, .. 32]} } | |||
There was a problem hiding this comment.
(Oh, doesn't matter: I see it's a hold-over from the old days where ~[0, .. 32] would construct a ~[int], not a ~([int, .. 32]).)
|
I removed additional functions and used |
|
Excuse me. If endianness is the problem, why don't you branch code by |
|
The original PR had functions that were branched by Hope these answer your question. |
|
OK, I understand. Thank you! |
bors
added a commit
that referenced
this pull request
May 28, 2014
Because IPv4 address conversion doesn't consider big-endian target, I add functions to handle that. These function names may need to be changed, but I can't come up with a good one.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
…osure, r=Veykril Convert nested function to closure assist Continuation of / closes rust-lang#13467. Resolves rust-lang#13230. r? `@Veykril`
flip1995
added a commit
to flip1995/rust
that referenced
this pull request
Apr 3, 2025
This PR enables the new ability to collapse `if` statements containing comments (without losing them) in Clippy sources, excluding tests and lintcheck, where the default behaviour (no collapsing in presence of comments) is preserved. To be applied after rust-lang#14231. When it is applied, rust-lang#14455 will be marked as ready for review, then rust-lang#14228 afterwards. changelog: none r? ghost
flip1995
added a commit
to flip1995/rust
that referenced
this pull request
Apr 3, 2025
…4481) Until `if let` chains are stabilized, we do not collapse them together or with other `if` expressions unless the `let_chains` feature is enabled. This is the case for example in Clippy sources. This was made possible by converting the `collapsible_if` to a late lint to get access to the set of enabled features. This allows this PR to supersede rust-lang#14455 and no longer require an additional configuration option. The three commits are, in order: - a conversion of the existing early lint to a late lint, with no new feature or tests changes - the addition of the `let_chains` feature detection and action, and tests - the application of the enhanced lint to Clippy sources (136 files modified) changelog: [`collapsible_if`]: recognize the rust compiler `let_chains` feature r? @flip1995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because IPv4 address conversion doesn't consider big-endian target, I add functions to handle that.
These function names may need to be changed, but I can't come up with a good one.