Add a method to dump MIR in the middle of MIR building #144780
Conversation
|
rustbot has assigned @petrochenkov. Use |
rustbot
added
S-waiting-on-review
|
I used this while debugging a loop match issue with @folkertdev. I figured it could be useful for others too in the future. |
| self.coroutine.clone(), | ||
| None, | ||
| ); | ||
| //body.coverage_info_hi = self.coverage_info.clone().map(|b| b.into_done()); |
There was a problem hiding this comment.
The coverage info builder is not Clone and I'm not sure if we should implement Clone for it anyway..
There was a problem hiding this comment.
I think it's fine to implement Clone for this, but maybe the people who implemented coverage think differently? cc @Zalathar
There was a problem hiding this comment.
Should be fine I think.
I have some other half-formed ideas about how to get the same result, but for this PR I don't mind just slapping #[derive(Clone)] on a few data structures.
There was a problem hiding this comment.
I've posted a draft PR at #145141 that shows how to avoid cloning the builder itself, by making the build method not consume self.
Feel free to incorporate it into this PR if you want, or we can merge it separately, whatever's more convenient for you.
There was a problem hiding this comment.
I've added something like your PR except as a separate method to avoid extra allocations when not doing a dump.
|
r? mir |
This makes it easier to debug issues with MIR building by inserting dump_for_debugging calls around the suspected code responsible for the bad MIR.
bjorn3
force-pushed
the
mir_build_debug
branch
from
2978c66 to
1662a75
Compare
|
Some changes occurred in coverage instrumentation. cc @Zalathar |
bjorn3
force-pushed
the
mir_build_debug
branch
from
1662a75 to
7287b93
Compare
This comment has been minimized.
This comment has been minimized.
bjorn3
force-pushed
the
mir_build_debug
branch
from
7287b93 to
695473a
Compare
This makes it easier to debug issues with MIR building by inserting dump_for_debugging calls around the suspected code responsible for the bad MIR.