Skip to content

syntax: Fix span on illegal ABI errors #14517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

syntax: Fix span on illegal ABI errors #14517

wants to merge 1 commit into from

Conversation

lucy
Copy link
Contributor

@lucy lucy commented May 29, 2014

Fixes #8537
Fixes #14499 (duplicate of #8537)

Old:

test.rs:2   pub extern "xxxxx" fn add(x: int, y: int) -> int {
                               ^~

New:

test.rs:2   pub extern "xxxxx" fn add(x: int, y: int) -> int {
                       ^~~~~~~

@alexcrichton
Copy link
Member

Can you add a test for this as well? A test may look like

// src/test/compile-fail/foo.rs
pub extern
  "invalid-abi" //~ ERROR: ...
fn foo() {}

fn main() {}

@lucy
Copy link
Contributor Author

lucy commented May 29, 2014

@alexcrichton done

bors added a commit that referenced this pull request May 30, 2014
Fixes #8537
Fixes #14499 (duplicate of #8537)

Old:
```rust
test.rs:2 	pub extern "xxxxx" fn add(x: int, y: int) -> int {
          	                   ^~
```

New:
```rust
test.rs:2 	pub extern "xxxxx" fn add(x: int, y: int) -> int {
          	           ^~~~~~~
```
@bors bors closed this May 30, 2014
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2023
internal: Shuffle around some hir_def modules
flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 3, 2025
…4517)

A discrepancy between the `cmake` version available on the runners and
the one required by the `aws-lc-sys` dependency prevents the crate from
building.

changelog: none

r? @flip1995
cc @Alexendoo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error spans for illegal extern "ABI" Incorrect spans for ABIs that do not match architecture
3 participants