Skip to content

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Aug 13, 2025

Fixes #118027.

We don't plan to add a way to not escape the first #, so at least we add a more complete example in the rustdoc book with a macro making use of that.

@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2025

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 13, 2025
@fmease
Copy link
Member

fmease commented Aug 13, 2025

Thanks! :)

r? fmease @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 13, 2025

📌 Commit dc0707a has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 13, 2025
…fmease

Add another example for escaped `#` character in doctest in rustdoc book

Fixes rust-lang#118027.

We don't plan to add a way to not escape the first `#`, so at least we add a more complete example in the rustdoc book with a macro making use of that.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 13, 2025
…fmease

Add another example for escaped `#` character in doctest in rustdoc book

Fixes rust-lang#118027.

We don't plan to add a way to not escape the first `#`, so at least we add a more complete example in the rustdoc book with a macro making use of that.
bors added a commit that referenced this pull request Aug 13, 2025
Rollup of 9 pull requests

Successful merges:

 - #144761 (aarch64: Make `outline-atomics` a known target feature)
 - #144949 (More `Printer` cleanups)
 - #144955 (search graph: lazily update parent goals)
 - #144962 (Add aarch64_be-unknown-none-softfloat target)
 - #145153 (Handle macros with multiple kinds, and improve errors)
 - #145241 ([AVR] Changed data_layout)
 - #145341 (Install libgccjit into the compiler's sysroot when cg_gcc is enabled)
 - #145349 (Correctly handle when there are no unstable items in the documented crate)
 - #145356 (Add another example for escaped `#` character in doctest in rustdoc book)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bb46a20 into rust-lang:master Aug 13, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Aug 13, 2025
Rollup merge of #145356 - GuillaumeGomez:doctest-escaped, r=fmease

Add another example for escaped `#` character in doctest in rustdoc book

Fixes #118027.

We don't plan to add a way to not escape the first `#`, so at least we add a more complete example in the rustdoc book with a macro making use of that.
@rustbot rustbot added this to the 1.91.0 milestone Aug 13, 2025
@GuillaumeGomez GuillaumeGomez deleted the doctest-escaped branch August 14, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc: Give users the option to opt out of ### substitution in code blocks
5 participants