Skip to content

Add codegen-llvm regression tests #145380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

okaneco
Copy link
Contributor

@okaneco okaneco commented Aug 14, 2025

Most of these regressions deal with elimination of panics and bounds checks that were fixed upstream by LLVM.

closes #141497
closes #131162
closes #129583
closes #110971
closes #91109
closes #80075
closes #74917
closes #71997
closes #71257
closes #59352

@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 14, 2025
// CHECK-LABEL: @is_inter_or_switch
#[no_mangle]
pub fn is_inter_or_switch(f: FrameType) -> bool {
// CHECK-NOT: ADD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a little brittle -- maybe we should check a more specific sequence of instructions? Or some other form of assertion that's not "no adds".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can change this to the specific sequence of checking and-cmp-ret in addition to the check-not.

This was the IR change from that issue, the subtraction being unwanted.

define i1 @src(i8 range(i8 0, 4) %arg) {
-  %add = add nsw i8 %arg, -1
  %and = and i8 %add, -3
  %cmp = icmp eq i8 %and, 0
  ret i1 %cmp
}

#[no_mangle]
pub fn check_no_compare(v: &mut Vec<f32>) {
// CHECK-NOT: icmp
// CHECK-NOT: br
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also seems brittle -- I could see a future compiler making this just call Vec::clear (given that the code sequence is the same for all 4-byte vec values, and maybe even for all T: Copy vec values?).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what to do so I'll back this test out then.

1.29 codegen - https://rust.godbolt.org/z/9qcPPMh67
1.30 codegen - https://rust.godbolt.org/z/7qK1rojYG

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2025
Most of these regressions concern elimination of panics and bounds
checks that were fixed upstream by LLVM.
@okaneco okaneco force-pushed the add-codegen-tests branch from b109232 to 9e28de2 Compare August 21, 2025 02:36
@okaneco
Copy link
Contributor Author

okaneco commented Aug 21, 2025

I removed the vec clear test and that issue from the PR message.
I made the other test an explicit sequence instead of no additions.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment