Rollup of 11 pull requests #145488

Zalathar · 2025-08-16T10:38:01Z

Successful merges:

Extend QueryStability to handle IntoIterator implementations #139345 (Extend QueryStability to handle IntoIterator implementations)
Fix outdated doc comment #144838 (Fix outdated doc comment)
Port #[custom_mir(..)] to the new attribute system #145206 (Port #[custom_mir(..)] to the new attribute system)
Implement declarative (macro_rules!) derive macros (RFC 3698) #145208 (Implement declarative (macro_rules!) derive macros (RFC 3698))
Fix -Zregparm for LLVM builtins #145309 (Fix -Zregparm for LLVM builtins)
Add codegen test for issue 122734 #145355 (Add codegen test for issue 122734)
cg_llvm: Use LLVM-C bindings for LLVMSetTailCallKind, LLVMGetTypeKind #145420 (cg_llvm: Use LLVM-C bindings for LLVMSetTailCallKind, LLVMGetTypeKind)
Add static glibc to the nix dev shell #145451 (Add static glibc to the nix dev shell)
Speedup copy_src_dirs in bootstrap #145460 (Speedup copy_src_dirs in bootstrap)
Fix typo in doc for library/std/src/fs.rs#set_permissions #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
Fix deprecation attributes on foreign statics #145485 (Fix deprecation attributes on foreign statics)

r? @ghost
@rustbot modify labels: rollup

set * Enforce the `-Zregparm=N` flag by setting the NumRegisterParameters LLVM module flag * Add assembly tests verifying that the parameters are passed in registers for reparm values 1, 2, and 3, for both LLVM intrinsics and non-builtin functions * Add c_void type to minicore

This handles various kinds of errors, but does not allow applying the derive yet. This adds the feature gate `macro_derive`.

Add infrastructure to apply a derive macro to arguments, consuming and returning a `TokenTree` only. Handle `SyntaxExtensionKind::MacroRules` when expanding a derive, if the macro's kinds support derive. Add tests covering various cases of `macro_rules` derives. Note that due to a pre-existing FIXME in `expand.rs`, derives are re-queued and some errors get emitted twice. Duplicate diagnostic suppression makes them not visible, but the FIXME should still get fixed.

this fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change

Fix adjacent code Fix duplicate warning; merge test into `tests/ui-fulldeps/internal-lints` Use `rustc_middle::ty::FnSig::inputs` Address two review comments - rust-lang#139345 (comment) - rust-lang#139345 (comment) Use `Instance::try_resolve` Import `rustc_middle::ty::Ty` as `Ty` rather than `MiddleTy` Simplify predicate handling Add more `#[allow(rustc::potential_query_instability)]` following rebase Remove two `#[allow(rustc::potential_query_instability)]` following rebase Address review comment Update compiler/rustc_lint/src/internal.rs Co-authored-by: lcnr <[email protected]>

"privalage" -> "privilege"

The target is removed by `copy_link` too, so no need to duplicate the syscall.

…nabled

Extend `QueryStability` to handle `IntoIterator` implementations This PR extends the `rustc::potential_query_instability` lint to check values passed as `IntoIterator` implementations. Full disclosure: I want the lint to warn about this line (please see rust-lang#138871 for why): https://github.com/rust-lang/rust/blob/aa8f0fd7163a2f23aa958faed30c9c2b77b934a5/src/librustdoc/json/mod.rs#L261 However, the lint warns about several other lines as well. Final note: the functions `get_callee_generic_args_and_args` and `get_input_traits_and_projections` were copied directly from [Clippy's source code](https://github.com/rust-lang/rust/blob/4fd8c04da0674af2c51310c9982370bfadfa1b98/src/tools/clippy/clippy_lints/src/methods/unnecessary_to_owned.rs#L445-L496).

Fix outdated doc comment This updates the documentation comment for `Type::is_doc_subtype_of` to more accurately describe its purpose as a subtyping check, rather than equality fixes rust-lang#138572 r? ``@tgross35``

…szelmann Port `#[custom_mir(..)]` to the new attribute system r? `@jdonszelmann`

…enkov Implement declarative (`macro_rules!`) derive macros (RFC 3698) This is a draft for review, and should not be merged yet. This is layered atop rust-lang#145153 , and has only two additional commits atop that. The first handles parsing and provides a test for various parse errors. The second implements expansion and handles application. This implements RFC 3698, "Declarative (`macro_rules!`) derive macros". Tracking issue: rust-lang#143549 This has one remaining issue, which I could use some help debugging: in `tests/ui/macros/macro-rules-derive-error.rs`, the diagnostics for `derive(fn_only)` (for a `fn_only` with no `derive` rules) and `derive(ForwardReferencedDerive)` both get emitted twice, as a duplicate diagnostic. From what I can tell via adding some debugging code, `unresolved_macro_suggestions` is getting called twice from `finalize_macro_resolutions` for each of them, because `self.single_segment_macro_resolutions` has two entries for the macro, with two different `parent_scope` values. I'm not clear on why that happened; it doesn't happen with the equivalent code using attrs. I'd welcome any suggestions for fixing this.

…ross35 Fix `-Zregparm` for LLVM builtins This fixes the issue where `-Zregparm=N` was not working correctly when calling LLVM intrinsics By default on `x86-32`, arguments are passed on the stack. The `-Zregparm=N` flag allows the first `N` arguments to be passed in registers instead. When calling intrinsics like `memset`, LLVM still passes parameters on the stack, which prevents optimizations like tail calls. As proposed by ``@tgross35,`` I fixed this by setting the `NumRegisterParameters` LLVM module flag to `N` when the `-Zregparm=N` is set. ```rust // compiler/rust_codegen_llvm/src/context.rs#375-382 if let Some(regparm_count) = sess.opts.unstable_opts.regparm { llvm::add_module_flag_u32( llmod, llvm::ModuleFlagMergeBehavior::Error, "NumRegisterParameters", regparm_count, ); } ``` [Here](https://rust.godbolt.org/z/YMezreo48) is a before/after compiler explorer. Here is the final result for the code snippet in the original issue: ```asm entrypoint: push esi mov esi, eax mov eax, ecx mov ecx, esi pop esi jmp memset ; Tail call parameters in registers ``` Fixes: rust-lang#145271

Add codegen test for issue 122734 Closes rust-lang#122734

cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind` This PR replaces two existing `LLVMRust` bindings with equivalent calls to the LLVM-C API. For `LLVMGetTypeKind`, we avoid the UB hazard by declaring the foreign function to return `RawEnum<TypeKind>` (which is a wrapper around `u32`), and then perform checked conversion from `u32` to `TypeKind`.

…rieb Add static glibc to the nix dev shell This fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change.

…dirs, r=jieyouxu Speedup `copy_src_dirs` in bootstrap I was kinda offended by how slow it was. Just the `copy_src_dirs` part took ~3s locally in the `x dist rustc-src` step. In release mode it was just 1s, but that's kind of cheating (I wonder if we should build bootstrap in release mode on CI though...). Did some basic optimizations to bring it down to ~1s also in debug mode. Maybe it's overkill, due to rust-lang#145455. Up to you whether we should merge it or close it :) r? `@jieyouxu`

Fix typo in doc for library/std/src/fs.rs#set_permissions "privalage" -> "privilege". Was reading the docs and have noticed this.

…rgets, r=jdonszelmann Fix deprecation attributes on foreign statics r? `@jdonszelmann` Fixes rust-lang#145437

Zalathar · 2025-08-16T10:38:23Z

@bors r+ rollup=never p=5

bors · 2025-08-16T10:38:26Z

📌 Commit 16fe165 has been approved by Zalathar

It is now in the queue for this repository.

Zalathar · 2025-08-16T10:40:42Z

@bors try jobs=test-various,x86_64-gnu-llvm-20-1

Rollup of 11 pull requests try-job: test-various try-job: x86_64-gnu-llvm-20-1

rust-bors · 2025-08-16T12:18:19Z

☀️ Try build successful (CI)
Build commit: 3427cb0 (3427cb0bcbb222dba887bd0803a850f9f44e998d, parent: 1ae7c4907275f10b3db9e886bc8809ec063e45ee)

bors · 2025-08-16T15:25:20Z

⌛ Testing commit 16fe165 with merge a387a0c...

Rollup of 11 pull requests Successful merges: - #139345 (Extend `QueryStability` to handle `IntoIterator` implementations) - #144838 (Fix outdated doc comment) - #145206 (Port `#[custom_mir(..)]` to the new attribute system) - #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698)) - #145309 (Fix `-Zregparm` for LLVM builtins) - #145355 (Add codegen test for issue 122734) - #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`) - #145451 (Add static glibc to the nix dev shell) - #145460 (Speedup `copy_src_dirs` in bootstrap) - #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions) - #145485 (Fix deprecation attributes on foreign statics) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-08-16T15:39:21Z

💔 Test failed - checks-actions

rust-log-analyzer · 2025-08-16T15:39:21Z

The job x86_64-gnu-llvm-19 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

fmease · 2025-08-16T17:03:36Z

Network failure (#t-infra > Non-stop network timeouts across auto-builds)

@bors retry

bors · 2025-08-17T01:53:22Z

⌛ Testing commit 16fe165 with merge 9c7b793...

Rollup of 11 pull requests Successful merges: - #139345 (Extend `QueryStability` to handle `IntoIterator` implementations) - #144838 (Fix outdated doc comment) - #145206 (Port `#[custom_mir(..)]` to the new attribute system) - #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698)) - #145309 (Fix `-Zregparm` for LLVM builtins) - #145355 (Add codegen test for issue 122734) - #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`) - #145451 (Add static glibc to the nix dev shell) - #145460 (Speedup `copy_src_dirs` in bootstrap) - #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions) - #145485 (Fix deprecation attributes on foreign statics) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-08-17T02:30:09Z

The job x86_64-gnu-llvm-19-3 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

61 
- error: using `into_iter` can result in unstable query results
-   --> $DIR/query_stability.rs:38:38
-    |
- LL |     FxHashMap::<u32, i32>::default().extend(x);
-    |                                      ^^^^^^^^^
-    |
-    = note: if you believe this case to be fine, allow this lint and add a comment explaining your rationale
- 
- error: using `into_iter` can result in unstable query results
---
To only update this specific test, also pass `--test-args internal-lints/query_stability.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustc" "/checkout/tests/ui-fulldeps/internal-lints/query_stability.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-sysroot" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/internal-lints/query_stability" "-A" "unused" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Z" "unstable-options"
stdout: none
--- stderr -------------------------------
error: using `drain` can result in unstable query results
##[error]  --> /checkout/tests/ui-fulldeps/internal-lints/query_stability.rs:13:16
   |
---

error: using `keys` can result in unstable query results
##[error]  --> /checkout/tests/ui-fulldeps/internal-lints/query_stability.rs:26:15
   |
LL |     let _ = x.keys();
   |               ^^^^
   |
   = note: if you believe this case to be fine, allow this lint and add a comment explaining your rationale

error: using `values` can result in unstable query results

bors · 2025-08-17T02:30:54Z

💔 Test failed - checks-actions

Kivooeo and others added 26 commits August 5, 2025 01:21

updated doc comment

970ac40

Add test for issue 122734

9b92069

mbe: Parse macro derive rules

8fb98ef

This handles various kinds of errors, but does not allow applying the derive yet. This adds the feature gate `macro_derive`.

Use LLVMSetTailCallKind

c64c6d8

Port #[custom_mir(..)] to the new attribute system

51bccdd

Use LLVMGetTypeKind

e193b53

add static glibc to the nix dev shell

1d00627

this fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change

Fix typo in doc for library/std/src/fs.rs#set_permissions

9fab380

"privalage" -> "privilege"

Do not call fs::remove_file in cp_link_filtered_recurse

5107ac9

The target is removed by `copy_link` too, so no need to duplicate the syscall.

Optimize copy_src_dirs

cdea62d

Don't show foreign types as an allowed target if the feature is not e…

e8f90b1

…nabled

Fix deprecation attribute on foreign statics & types

a69ba29

Rollup merge of rust-lang#144838 - Kivooeo:doc-subtype, r=notriddle

34bcc9a

Fix outdated doc comment This updates the documentation comment for `Type::is_doc_subtype_of` to more accurately describe its purpose as a subtyping check, rather than equality fixes rust-lang#138572 r? ``@tgross35``

Rollup merge of rust-lang#145206 - scrabsha:push-uxovoqzrxnlx, r=jdon…

37e646b

…szelmann Port `#[custom_mir(..)]` to the new attribute system r? `@jdonszelmann`

Rollup merge of rust-lang#145355 - clubby789:option-match-eq, r=nikic

e2c99f1

Add codegen test for issue 122734 Closes rust-lang#122734

Rollup merge of rust-lang#145451 - WaffleLapkin:norailoveyou, r=Norat…

55fd065

…rieb Add static glibc to the nix dev shell This fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change.

Rollup merge of rust-lang#145476 - alurm:patch-1, r=ibraheemdev

0f1ea54

Fix typo in doc for library/std/src/fs.rs#set_permissions "privalage" -> "privilege". Was reading the docs and have noticed this.

Rollup merge of rust-lang#145485 - JonathanBrouwer:fix-deprecation-ta…

16fe165

…rgets, r=jdonszelmann Fix deprecation attributes on foreign statics r? `@jdonszelmann` Fixes rust-lang#145437

rustbot added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Aug 16, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2025

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Aug 16, 2025

Auto merge of #145488 - Zalathar:rollup-xx2b6w1, r=<try>

3427cb0

Rollup of 11 pull requests try-job: test-various try-job: x86_64-gnu-llvm-20-1

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 16, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 17, 2025

This was referenced Aug 17, 2025

Extend QueryStability to handle IntoIterator implementations #139345

Open

Rollup of 10 pull requests #145517

Closed

Zalathar closed this Aug 17, 2025

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2025

Zalathar deleted the rollup-xx2b6w1 branch August 17, 2025 02:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 11 pull requests #145488

Rollup of 11 pull requests #145488

Zalathar commented Aug 16, 2025 •

edited by rustbot

Loading

Uh oh!

Zalathar commented Aug 16, 2025

Uh oh!

bors commented Aug 16, 2025

Uh oh!

Zalathar commented Aug 16, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Aug 16, 2025

Uh oh!

bors commented Aug 16, 2025

Uh oh!

bors commented Aug 16, 2025

Uh oh!

rust-log-analyzer commented Aug 16, 2025

Uh oh!

fmease commented Aug 16, 2025

Uh oh!

bors commented Aug 17, 2025

Uh oh!

rust-log-analyzer commented Aug 17, 2025

Uh oh!

bors commented Aug 17, 2025

Uh oh!

Uh oh!

Rollup of 11 pull requests #145488

Rollup of 11 pull requests #145488

Conversation

Zalathar commented Aug 16, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Aug 16, 2025

Uh oh!

bors commented Aug 16, 2025

Uh oh!

Zalathar commented Aug 16, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Aug 16, 2025

Uh oh!

bors commented Aug 16, 2025

Uh oh!

bors commented Aug 16, 2025

Uh oh!

rust-log-analyzer commented Aug 16, 2025

Uh oh!

fmease commented Aug 16, 2025

Uh oh!

bors commented Aug 17, 2025

Uh oh!

rust-log-analyzer commented Aug 17, 2025

Uh oh!

bors commented Aug 17, 2025

Uh oh!

Uh oh!

Zalathar commented Aug 16, 2025 •

edited by rustbot

Loading