-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Issue-141806: Remove sizedness_fast_path in fulfill.rs #145492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It solves rust-lang#141806. sizedness_fast_path in FulfillProcessor.process_obligation causes the panic if the Sized type doesn't exist. Signed-off-by: Shunpoco <[email protected]>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Shunpoco <[email protected]>
This comment has been minimized.
This comment has been minimized.
The job Click to see the possible cause of the failure (guessed by this bot)
|
This solution does not look correct and also has a performance implication. This needs a lot more detailed explanation for why the ICE occurs in the first place. |
Yes, at first I thought that the problem is solved by deleting the block, but the actual problem is much deeper. |
Context
Fix #141806
If Sized type doesn't exist, the ICE happens. This ICE is from sizedness_fast_path() call in FulfillProcessor.process_abligation.
Originally the function call was added for performance improvement in #139577 .
Change