Refactor attribute parsing to improve ergonomics and some diagnostics

[jdonszelmann]

No description provided.

[rustbot]

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

[jdonszelmann]

@rustbot review

[davidtwco]

@bors r+

[bors]

📌 Commit e5c14c3 has been approved by davidtwco

It is now in the queue for this repository.

[jieyouxu]

Merge conflict.
@bors r-

[jdonszelmann]

@rustbot review

[jdonszelmann]

the rangediff shows a test output changed related to attrs on foreign types which got introduced very recently, hence the conflict. That's why I pushed again to fix that, that was unintentional but the current version is good in that regard.

[jdonszelmann]

i.e. the rangediff shows this bit as removed but I added it back in afterwards:

[bors]

☔ The latest upstream changes (presumably #145600) made this pull request unmergeable. Please resolve the merge conflicts.

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[davidtwco]

@bors delegate+

[bors]

✌️ @jdonszelmann, you can now approve this pull request!

If @davidtwco told you to "r=me" after making some further change, please make that change, then do @bors r=@davidtwco

[jdonszelmann]

@bors r=davidtwco

[bors]

📌 Commit 49d030b has been approved by davidtwco

It is now in the queue for this repository.