Skip to content

Conversation

JonathanBrouwer
Copy link
Contributor

This does actually working suprisingly enough, applying deprecation to all methods in the impl block

r? @jdonszelmann

@rustbot
Copy link
Collaborator

rustbot commented Aug 30, 2025

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 30, 2025

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

@jdonszelmann
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 30, 2025

📌 Commit fcd6f28 has been approved by jdonszelmann

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2025
@jdonszelmann
Copy link
Contributor

@bors rollup

@bors
Copy link
Collaborator

bors commented Aug 30, 2025

⌛ Testing commit fcd6f28 with merge 523d399...

@bors
Copy link
Collaborator

bors commented Aug 30, 2025

☀️ Test successful - checks-actions
Approved by: jdonszelmann
Pushing 523d399 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 30, 2025
@bors bors merged commit 523d399 into rust-lang:master Aug 30, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 30, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0f50696 (parent) -> 523d399 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 523d3999dcd4bbd9a52661a29dbd7351a9c5fb03 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 5773.8s -> 6735.0s (16.6%)
  2. dist-aarch64-msvc: 5862.5s -> 5314.6s (-9.3%)
  3. dist-apple-various: 3413.9s -> 3709.8s (8.7%)
  4. x86_64-gnu-llvm-19: 2402.4s -> 2609.2s (8.6%)
  5. aarch64-gnu-llvm-19-2: 2160.1s -> 2340.7s (8.4%)
  6. dist-x86_64-windows-gnullvm: 4730.3s -> 5097.3s (7.8%)
  7. aarch64-gnu-debug: 4375.3s -> 4707.8s (7.6%)
  8. aarch64-apple: 5051.3s -> 5428.7s (7.5%)
  9. dist-x86_64-illumos: 6279.3s -> 5849.1s (-6.8%)
  10. pr-check-1: 1384.1s -> 1464.6s (5.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (523d399): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.8% [2.5%, 5.1%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 465.405s -> 465.403s (-0.00%)
Artifact size: 388.57 MiB -> 388.58 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants