Skip to content

Conversation

jdonszelmann
Copy link
Contributor

@jdonszelmann jdonszelmann commented Sep 12, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

jdonszelmann and others added 10 commits September 9, 2025 15:16
This reverts commit 7ce620d.
The const-hacks introduces bugs, and they make the code harder to maintain.
Let's wait until we can constify these functions without changing their implementation.
Convert `no_std` and `no_core` to the new attribute infrastructure

r? ``@oli-obk``

Also added a test for these, since we didn't have any and I was kind of surprised new diagnostics didn't break anything hehe
…rage, r=tgross35

Improve `alloc::Layout` coverage

This PR improves the `core::alloc` coverage by adding a new test to `coretests` that cover the `Layout` methods when they error.

Tracking issue: rust-lang#55724
…rkingjubilee

Revert "Constify SystemTime methods"

This reverts rust-lang#144519. The const-hacks introduces bugs, and they make the code harder to maintain. Let's wait until we can constify these functions without changing their implementation.

Fixes rust-lang#146228.
Closes rust-lang#144517 (since the feature is gone).
r? `@tgross35`
Cc `@clarfonthey`
…age, r=Noratrieb

Improve `core::char` coverage

This PR improves the `core::char` coverage by adding new tests to `coretests`

r? `@workingjubilee`
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) O-hermit Operating System: Hermit O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 12, 2025
@jdonszelmann
Copy link
Contributor Author

@bors r+ p=5 rollup=never

@bors
Copy link
Collaborator

bors commented Sep 12, 2025

📌 Commit 7078e76 has been approved by jdonszelmann

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2025
bors added a commit that referenced this pull request Sep 12, 2025
Rollup of 4 pull requests

Successful merges:

 - #146389 (Convert `no_std` and `no_core` to the new attribute infrastructure)
 - #146452 (Improve `alloc::Layout` coverage)
 - #146473 (Revert "Constify SystemTime methods")
 - #146477 (Improve `core::char` coverage)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Sep 12, 2025

⌛ Testing commit 7078e76 with merge 16288b8...

@rust-log-analyzer
Copy link
Collaborator

The job dist-various-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

error: `Sub` is not yet stable as a const trait
  --> library/std/src/sys/pal/wasip2/time.rs:56:25
   |
56 |             None => Err(other.0 - self.0),
   |                         ^^^^^^^^^^^^^^^^
   |
help: add `#![feature(const_ops)]` to the crate attributes to enable
  --> library/std/src/lib.rs:432:1
   |
432+ #![feature(const_ops)]
   |

error: `Try` is not yet stable as a const trait
  --> library/std/src/sys/pal/wasip2/time.rs:62:25
   |
62 |         Some(SystemTime(self.0.checked_add(*other)?))
   |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
help: add `#![feature(const_try)]` to the crate attributes to enable
  --> library/std/src/lib.rs:432:1
   |
432+ #![feature(const_try)]
   |

error: `FromResidual` is not yet stable as a const trait
  --> library/std/src/sys/pal/wasip2/time.rs:62:25
   |
62 |         Some(SystemTime(self.0.checked_add(*other)?))
   |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
help: add `#![feature(const_try)]` to the crate attributes to enable
  --> library/std/src/lib.rs:432:1
   |
432+ #![feature(const_try)]
   |

error: `Try` is not yet stable as a const trait
  --> library/std/src/sys/pal/wasip2/time.rs:67:25
   |
67 |         Some(SystemTime(self.0.checked_sub(*other)?))
   |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
help: add `#![feature(const_try)]` to the crate attributes to enable
  --> library/std/src/lib.rs:432:1
   |
432+ #![feature(const_try)]
   |

error: `FromResidual` is not yet stable as a const trait
  --> library/std/src/sys/pal/wasip2/time.rs:67:25
   |
67 |         Some(SystemTime(self.0.checked_sub(*other)?))
   |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
help: add `#![feature(const_try)]` to the crate attributes to enable
  --> library/std/src/lib.rs:432:1
   |

@bors
Copy link
Collaborator

bors commented Sep 13, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 13, 2025
@jieyouxu
Copy link
Member

Yeah, seems like #146473.

@jieyouxu jieyouxu closed this Sep 13, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) O-hermit Operating System: Hermit O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-windows Operating system: Windows rollup A PR which is a rollup T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants