Skip to content

remove duplicated columns from rustc_error_code::error_codes! #146584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove duplicated columns from rustc_error_code::error_codes! #146584

wants to merge 1 commit into from
+535 −562

Conversation

cyrgani
Copy link
Contributor

@cyrgani cyrgani commented Sep 15, 2025 •
edited
Loading

Possible because of #146308 , but currently still blocked on the next stage0 bump.

@cyrgani cyrgani added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Sep 15, 2025
@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 15, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@cyrgani cyrgani mentioned this pull request Sep 15, 2025
Open
@bors
Copy link
Collaborator

bors commented Sep 21, 2025

☔ The latest upstream changes (presumably #146592) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@cyrgani cyrgani marked this pull request as ready for review September 27, 2025 12:11
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 27, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 27, 2025

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 27, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 27, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@cyrgani cyrgani removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Sep 27, 2025
@GuillaumeGomez
Copy link
Member

Looks good to me, thanks!

Why did you mark it as blocked though?

Anyway, r=me once ready if no further changes.

@cyrgani
Copy link
Contributor Author

cyrgani commented Sep 27, 2025

Why did you mark it as blocked though?

Because it had to wait for #146636, which only merged a few hours ago.

@jieyouxu jieyouxu assigned GuillaumeGomez and unassigned jieyouxu Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cyrgani @rust-log-analyzer @bors @rustbot @GuillaumeGomez @jieyouxu