ci: x86_64-gnu-tools: Add --test-args regression test
#146606
Merged
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-CI
Enselic
added
S-waiting-on-author
Enselic
force-pushed
the
test-test-args
branch
from
e8fce89 to
457aa93
Compare
This comment has been minimized.
This comment has been minimized.
Enselic
force-pushed
the
test-test-args
branch
from
457aa93 to
8368fd9
Compare
Enselic
changed the title
--test-args regression test
This comment has been minimized.
This comment has been minimized.
Enselic
force-pushed
the
test-test-args
branch
from
8368fd9 to
11200b3
Compare
This comment has been minimized.
This comment has been minimized.
|
The test run was without the fix. So the test catches the bug, because the test fails without the fix. From the log: I will now rebase on master which has the fix. So if the test then passes, we know the test works as intended. |
Enselic
force-pushed
the
test-test-args
branch
from
11200b3 to
91cf067
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
The test passed after rebasing on the fix. So the test works and would have caught the bug (and will prevent regressions). @rustbot ready |
rustbot
added
S-waiting-on-review
Mark-Simulacrum
approved these changes
Sep 21, 2025
| # Any test can be used. We arbitrarily chose `tests/ui/lint/unused/unused-result.rs`. | ||
| python3 "$X_PY" test tests/ui --test-args tests/ui/lint/unused/unused-result.rs --force-rerun | | ||
| grep --fixed-strings 'test result: ok. 1 passed; 0 failed; 0 ignored;' || | ||
| ( echo "ERROR: --test-args functionality is broken" && exit 1 ) |
There was a problem hiding this comment.
Hm, I was thinking of more of a unit test directly in compiletest, but I think this seems OK too.
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 21, 2025
…ulacrum ci: x86_64-gnu-tools: Add `--test-args` regression test See rust-lang#146601 (comment) r? `@Mark-Simulacrum`
This was referenced Sep 21, 2025
bors
added a commit
that referenced
this pull request
Sep 21, 2025
Rollup of 4 pull requests Successful merges: - #143857 (Port #[macro_export] to the new attribute parsing infrastructure) - #146486 (Improve `core::sync::atomic` coverage) - #146606 (ci: x86_64-gnu-tools: Add `--test-args` regression test) - #146639 (std: merge definitions of `StdioPipes`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 21, 2025
Rollup merge of #146606 - Enselic:test-test-args, r=Mark-Simulacrum ci: x86_64-gnu-tools: Add `--test-args` regression test See #146601 (comment) r? ``@Mark-Simulacrum``
Muscraft
pushed a commit
to Muscraft/rust
that referenced
this pull request
Sep 24, 2025
…ulacrum ci: x86_64-gnu-tools: Add `--test-args` regression test See rust-lang#146601 (comment) r? ``@Mark-Simulacrum``
Muscraft
pushed a commit
to Muscraft/rust
that referenced
this pull request
Sep 24, 2025
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#143857 (Port #[macro_export] to the new attribute parsing infrastructure) - rust-lang#146486 (Improve `core::sync::atomic` coverage) - rust-lang#146606 (ci: x86_64-gnu-tools: Add `--test-args` regression test) - rust-lang#146639 (std: merge definitions of `StdioPipes`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #146601 (comment)
r? @Mark-Simulacrum