Skip to content

Allow shared access to Exclusive<T> when T: Sync #146675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2025
Merged

Allow shared access to Exclusive<T> when T: Sync #146675

merged 2 commits into from
Sep 28, 2025

Conversation

Jules-Bertholet
Copy link
Contributor

@Jules-Bertholet Jules-Bertholet commented Sep 17, 2025 •
edited
Loading

Addresses libs-api request in #98407 (comment).

Adds the following trait impls to Exclusive<T>, all bounded on T: Sync:

  • AsRef<T>
  • Clone
  • Copy
  • PartialEq
  • StructuralPartialEq
  • Eq
  • Hash
  • PartialOrd
  • Ord
  • Fn

@rustbot label T-libs-api

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 17, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 17, 2025
Mark-Simulacrum
Mark-Simulacrum reviewed Sep 21, 2025
View reviewed changes
@Mark-Simulacrum
Copy link
Member

r=me with commits squashed

@Jules-Bertholet
Copy link
Contributor Author

squashed

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 21, 2025

📌 Commit 97b2292 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 21, 2025
@matthiaskrgr
Rollup merge of rust-lang#146675 - Jules-Bertholet:sync-nonexclusive,…
1001c7d 
… r=Mark-Simulacrum

Allow shared access to `Exclusive<T>` when `T: Sync`

Addresses libs-api request in rust-lang#98407 (comment).

Adds the following trait impls to `Exclusive<T>`, all bounded on `T: Sync`:

- `AsRef<T>`
- `Clone`
- `Copy`
- `PartialEq`
- `StructuralPartialEq`
- `Eq`
- `Hash`
- `PartialOrd`
- `Ord`
- `Fn`

`@rustbot` label T-libs-api
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 21, 2025
Closed
@matthiaskrgr
Copy link
Member

@bors r- ci failing already

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 21, 2025
@rustbot rustbot added F-explicit_tail_calls `#![feature(explicit_tail_calls)]` WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Sep 21, 2025
@Jules-Bertholet
Copy link
Contributor Author

Just needed to bless some UI tests.

@rustbot label -F-explicit_tail_calls -WG-trait-system-refactor
@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed F-explicit_tail_calls `#![feature(explicit_tail_calls)]` WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 21, 2025
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 28, 2025

📌 Commit f1d6e00 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 28, 2025
@matthiaskrgr
Rollup merge of rust-lang#146675 - Jules-Bertholet:sync-nonexclusive,…
c83a917 
… r=Mark-Simulacrum

Allow shared access to `Exclusive<T>` when `T: Sync`

Addresses libs-api request in rust-lang#98407 (comment).

Adds the following trait impls to `Exclusive<T>`, all bounded on `T: Sync`:

- `AsRef<T>`
- `Clone`
- `Copy`
- `PartialEq`
- `StructuralPartialEq`
- `Eq`
- `Hash`
- `PartialOrd`
- `Ord`
- `Fn`

`@rustbot` label T-libs-api
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 28, 2025
Merged
bors added a commit that referenced this pull request Sep 28, 2025
@bors
Auto merge of #147128 - matthiaskrgr:rollup-mqey4c4, r=matthiaskrgr
c8905ea 
Rollup of 6 pull requests

Successful merges:

 - #140482 (std::net: update tcp deferaccept delay type to Duration.)
 - #141469 (Allow `&raw [mut | const]` for union field in safe code)
 - #144197 (TypeTree support in autodiff)
 - #146675 (Allow shared access to `Exclusive<T>` when `T: Sync`)
 - #147113 (Reland "Add LSX accelerated implementation for source file analysis")
 - #147120 (Fix --extra-checks=spellcheck to prevent cargo install every time)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 750e902 into rust-lang:master Sep 28, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 28, 2025
rust-timer added a commit that referenced this pull request Sep 28, 2025
@rust-timer
Unrolled build for #146675
4a0f000 
Rollup merge of #146675 - Jules-Bertholet:sync-nonexclusive, r=Mark-Simulacrum

Allow shared access to `Exclusive<T>` when `T: Sync`

Addresses libs-api request in #98407 (comment).

Adds the following trait impls to `Exclusive<T>`, all bounded on `T: Sync`:

- `AsRef<T>`
- `Clone`
- `Copy`
- `PartialEq`
- `StructuralPartialEq`
- `Eq`
- `Hash`
- `PartialOrd`
- `Ord`
- `Fn`

``@rustbot`` label T-libs-api
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Sep 29, 2025
@bors
Auto merge of #147128 - matthiaskrgr:rollup-mqey4c4, r=matthiaskrgr
378536f 
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#140482 (std::net: update tcp deferaccept delay type to Duration.)
 - rust-lang/rust#141469 (Allow `&raw [mut | const]` for union field in safe code)
 - rust-lang/rust#144197 (TypeTree support in autodiff)
 - rust-lang/rust#146675 (Allow shared access to `Exclusive<T>` when `T: Sync`)
 - rust-lang/rust#147113 (Reland "Add LSX accelerated implementation for source file analysis")
 - rust-lang/rust#147120 (Fix --extra-checks=spellcheck to prevent cargo install every time)

r? `@ghost`
`@rustbot` modify labels: rollup
@Jules-Bertholet Jules-Bertholet deleted the sync-nonexclusive branch September 29, 2025 13:24
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
@matthiaskrgr
Rollup merge of rust-lang#146675 - Jules-Bertholet:sync-nonexclusive,…
3c6ae45 
… r=Mark-Simulacrum

Allow shared access to `Exclusive<T>` when `T: Sync`

Addresses libs-api request in rust-lang#98407 (comment).

Adds the following trait impls to `Exclusive<T>`, all bounded on `T: Sync`:

- `AsRef<T>`
- `Clone`
- `Copy`
- `PartialEq`
- `StructuralPartialEq`
- `Eq`
- `Hash`
- `PartialOrd`
- `Ord`
- `Fn`

``@rustbot`` label T-libs-api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.92.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Jules-Bertholet @rustbot @Mark-Simulacrum @bors @rust-log-analyzer @matthiaskrgr