Skip to content

Make it possible to x install Cranelift and LLVM bitcode linker #146927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2025
Merged

Make it possible to x install Cranelift and LLVM bitcode linker #146927

merged 2 commits into from
Sep 27, 2025

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Sep 23, 2025

It was not possible to install these before, as they were not in the install step description list.

Fixes: #140331

r? @jieyouxu

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 23, 2025
@Kobzol Kobzol mentioned this pull request Sep 23, 2025
Closed
jieyouxu
jieyouxu approved these changes Sep 23, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

View changes since this review

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 23, 2025

📌 Commit ffca2f0 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 23, 2025
@matthiaskrgr
Rollup merge of rust-lang#146927 - Kobzol:install-clif, r=jieyouxu
41315de 
Make it possible to `x install` Cranelift and LLVM bitcode linker

It was not possible to install these before, as they were not in the install step description list.

Fixes: rust-lang#140331

r? `@jieyouxu`
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 23, 2025
Closed
bors added a commit that referenced this pull request Sep 23, 2025
@bors
Auto merge of #146943 - matthiaskrgr:rollup-oh3k78y, r=matthiaskrgr
357d59f 
Rollup of 8 pull requests

Successful merges:

 - #146818 (constify {float}::total_cmp())
 - #146896 (rustc-dev-guide subtree update)
 - #146898 (Update books)
 - #146899 (Fix a crash/mislex when more than one frontmatter closing possibility is considered)
 - #146904 (#140368 Mutex/RwLock/ReentrantLock::data_ptr to be const fn)
 - #146907 (add regression test for issue 146537)
 - #146927 (Make it possible to `x install` Cranelift and LLVM bitcode linker)
 - #146931 (miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr
Copy link
Member

@bors r-
#146943 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 23, 2025
@Kobzol
Copy link
Member Author

Kobzol commented Sep 24, 2025

@bors try jobs=i686-gnu-2

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Sep 24, 2025
@rust-bors
Auto merge of #146927 - Kobzol:install-clif, r=<try>
f1aa781 
Make it possible to `x install` Cranelift and LLVM bitcode linker

try-job: i686-gnu-2
@rust-bors
Copy link

rust-bors bot commented Sep 24, 2025

☀️ Try build successful (CI)
Build commit: f1aa781 (f1aa781871f35b5f337136fd2c314d660eb3f1b3, parent: 15283f6fe95e5b604273d13a428bab5fc0788f5a)

@Kobzol
Copy link
Member Author

Kobzol commented Sep 24, 2025

@bors r=jieyouxu rollup=never

Let's try again.

@bors
Copy link
Collaborator

bors commented Sep 24, 2025

📌 Commit a223343 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 24, 2025
@bors
Copy link
Collaborator

bors commented Sep 27, 2025

⌛ Testing commit a223343 with merge 4082d6a...

@bors
Copy link
Collaborator

bors commented Sep 27, 2025

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 4082d6a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 27, 2025
@bors bors merged commit 4082d6a into rust-lang:master Sep 27, 2025
12 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c0ee51f (parent) -> 4082d6a (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 4082d6a3f0347c2fc4b8c8d5a6a38ed7248fa161 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-rust-for-linux: 2991.4s -> 2574.2s (-13.9%)
  2. pr-check-2: 2714.2s -> 2375.8s (-12.5%)
  3. i686-gnu-1: 8406.5s -> 7385.7s (-12.1%)
  4. x86_64-gnu-aux: 7246.5s -> 6367.7s (-12.1%)
  5. dist-aarch64-apple: 6960.0s -> 6128.1s (-12.0%)
  6. i686-gnu-2: 6116.7s -> 5421.1s (-11.4%)
  7. aarch64-msvc-1: 7394.2s -> 6595.4s (-10.8%)
  8. x86_64-gnu-llvm-20: 2729.2s -> 2437.9s (-10.7%)
  9. i686-gnu-nopt-1: 8159.7s -> 7313.5s (-10.4%)
  10. dist-x86_64-netbsd: 5076.2s -> 4582.2s (-9.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4082d6a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 7.9% [7.9%, 7.9%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.9% [-4.1%, -3.8%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 471.818s -> 470.544s (-0.27%)
Artifact size: 388.10 MiB -> 388.12 MiB (0.01%)

@Kobzol Kobzol deleted the install-clif branch September 28, 2025 06:31
@github-actions github-actions bot mentioned this pull request Sep 29, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.92.0
Development

Successfully merging this pull request may close these issues.

-Zcodegen-backend no longer works on x.py installed rustc
6 participants
@Kobzol @jieyouxu @bors @matthiaskrgr @rust-timer @rustbot