Skip to content

more float constants #146934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

more float constants #146934

wants to merge 1 commit into from
+59 −4

Conversation

joshuarayton
Copy link
Contributor

@joshuarayton joshuarayton commented Sep 23, 2025 •
edited by rustbot
Loading

more float constants: sqrt(5), 1/sqrt(5), ln(3)
rename EGAMMA to GAMMA

Adds constants discussed in #103883
I discuss why I prefer the variable name GAMMA in the issue but if a majority disagrees then I can change it back.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 23, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@joshuarayton joshuarayton mentioned this pull request Sep 23, 2025
Closed
3 tasks
tgross35
tgross35 requested changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to file an ACP for this so the API team discusses it? It's an issue template at https://github.com/rust-lang/libs-team/issues, should be pretty easy.

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2025
@tgross35 tgross35 added the needs-acp This change is blocked on the author creating an ACP. label Sep 23, 2025
@joshuarayton joshuarayton mentioned this pull request Sep 24, 2025
Open
@joshuarayton
Copy link
Contributor Author

Would you be able to file an ACP for this so the API team discusses it? It's an issue template at https://github.com/rust-lang/libs-team/issues, should be pretty easy.

View changes since this review

Done at: rust-lang/libs-team#661

@tgross35 tgross35 added S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 26, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@bors
Copy link
Collaborator

bors commented Sep 28, 2025

☔ The latest upstream changes (presumably #147104) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 requested changes

Assignees

@tgross35 tgross35

Labels
needs-acp This change is blocked on the author creating an ACP. S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshuarayton @rustbot @bors @tgross35