Add a leading dash to linker plugin arguments in the gcc codegen #147127
+51
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in compiler/rustc_codegen_ssa Some changes occurred in compiler/rustc_codegen_gcc Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 |
rustbot
added
A-LLVM
|
I am unable to test that this actually works since a get a segfault in GCC that I have a hard time reproducing when not running cargo, so I'm not sure how to debug. I suggest anyway that we start with this: maybe I'll be able to get further on the cg_gcc side. |
antoyo
force-pushed
the
fix/gcc-linker-plugin
branch
from
4535bde to
5aa7fb7
Compare
bjorn3
approved these changes
Sep 28, 2025
antoyo
force-pushed
the
fix/gcc-linker-plugin
branch
from
5aa7fb7 to
7fcbc5e
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 29, 2025
…orn3 Add a leading dash to linker plugin arguments in the gcc codegen Fix rust-lang#130583 r? `@bjorn3`
bors
added a commit
that referenced
this pull request
Sep 29, 2025
Rollup of 6 pull requests Successful merges: - #133477 (Detect tuple structs that are unconstructable due to re-export) - #140916 (Fix unuseful span in type error in some format_args!() invocations) - #146979 (constify Default on Nanoseconds) - #147090 (Skip stack overflow handler for panic=immediate-abort) - #147092 (Do not compute optimized MIR if code does not type-check.) - #147127 (Add a leading dash to linker plugin arguments in the gcc codegen) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Sep 29, 2025
Rollup of 7 pull requests Successful merges: - #133477 (Detect tuple structs that are unconstructable due to re-export) - #146929 (compiletest: Remove old-output-capture and become a stage0 bootstrap tool) - #146979 (constify Default on Nanoseconds) - #147092 (Do not compute optimized MIR if code does not type-check.) - #147112 (all 48 keywords in just 300 characters) - #147122 (Fix some crash-test directives) - #147127 (Add a leading dash to linker plugin arguments in the gcc codegen) r? `@ghost` `@rustbot` modify labels: rollup
tautschnig
added a commit
to tautschnig/kani
that referenced
this pull request
Sep 30, 2025
Relevant upstream PRs: - rust-lang/rust#147127 (Add a leading dash to linker plugin arguments in the gcc codegen) Resolves: model-checking#4387
tautschnig
added a commit
to tautschnig/kani
that referenced
this pull request
Sep 30, 2025
Relevant upstream PRs: - rust-lang/rust#147127 (Add a leading dash to linker plugin arguments in the gcc codegen) Resolves: model-checking#4387
github-merge-queue bot
pushed a commit
to model-checking/kani
that referenced
this pull request
Sep 30, 2025
Relevant upstream PRs: - rust-lang/rust#147127 (Add a leading dash to linker plugin arguments in the gcc codegen) Resolves: #4387 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #130583
r? @bjorn3