Forbid //@ compile-flags: -Cincremental= in tests
#147221
Open
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests should not try to manually enable incremental compilation with `-Cincremental`, because that typically results in stray directories being created in the repository root. Instead, use the `//@ incremental` directive, which instructs compiletest to handle the details of passing `-Cincremental` with a fresh directory.
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
rustbot
added
S-blocked
lqd
approved these changes
Oct 1, 2025
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
We should also change ui tests to not run tests under... weird places, but that's for another PR. |
|
This fixes #128057. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests should not try to manually enable incremental compilation with
-Cincremental, because that typically results in stray directories being created in the repository root.Instead, use the
//@ incrementaldirective, which instructs compiletest to handle the details of passing-Cincrementalwith a fresh directory.