rustc: Improve span for error about using a method as a field. #14905
+43
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of manufacturing a span, perhaps |
|
@alexcrichton Probably is a cleaner way to do it, compare latest commit. |
|
Looks good to me! With a squash I think this is good to go. |
libsyntax: ExprField now contains a SpannedIdent rather than Ident. [breaking-change]
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
feat: Render niches on hover
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 31, 2025
This lint was previously written very clumsily, not short-circuiting and doing a lot of unnecessary work. Now it makes sure to do the cheaper functions earlier and in general, is just smarter. (I specifically focused on minimizing binder instantiation Sadly, I'm not finding any relevant result in a benchmark. Still with the LLVM coverage instruments, the expensive bits are called lots of less times (The binder instantiation that I care about is reduced from 95k to 10k throughout our test suite). changelog:[`unit_return_expecting_ord`]: Optimize the lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only highlight the method name in the span.