rustdoc: Remove outdated syntax #14957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing some of rustdoc's rendering to use newer syntaxes rather than older syntaxes.
bors
added a commit
that referenced
this pull request
Jun 17, 2014
Fixing some of rustdoc's rendering to use newer syntaxes rather than older syntaxes.
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 7, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 7, 2023
bugfix : skip doc(hidden) default members fixes rust-lang#14957 . I have two questions : 1. I am definitely looking for a more idiomatic way for the things I added in `crates/ide-assists/src/utils.rs`. See `FIXME` in that file. 2. Would it be actually better to change `DefaultMethods` to something like ```rust enum DefaultMethods { Only( IgnoreHidden ( bool ) ) , None } ``` instead of adding a boolean to every function that calls `crates/ide-assists/src/utils.rs::filter_assoc_items`
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 13, 2025
…lang#14957) `clippy_lints::casts::utils::int_ty_to_nbits` used to return `0` to indicate that the argument was not an integral type. It is more idiomatic to use `Option<u64>` as a return type. Also, I've added a few `FIXME:` at places where only `f32` and `f64` are considered, as we now have `f16` and `f128` to deal with. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some of rustdoc's rendering to use newer syntaxes rather than older
syntaxes.