Skip to content

Fix ICE with nested macro_rules!-style macros #15342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libsyntax/parse/parser.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3243,7 +3243,7 @@ impl<'a> Parser<'a> {
None => {
// we only expect an ident if we didn't parse one
// above.
let ident_str = if id == token::special_idents::invalid {
let ident_str = if id.name == token::special_idents::invalid.name {
"identifier, "
} else {
""
Expand All @@ -3263,7 +3263,7 @@ impl<'a> Parser<'a> {
);
let hi = self.span.hi;

if id == token::special_idents::invalid {
if id.name == token::special_idents::invalid.name {
return box(GC) spanned(lo, hi, StmtMac(
spanned(lo, hi, MacInvocTT(pth, tts, EMPTY_CTXT)), false));
} else {
Expand Down
34 changes: 34 additions & 0 deletions src/test/compile-fail/issue-10536.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// We only want to assert that this doesn't ICE, we don't particularly care
// about whether it nor it fails to compile.

// error-pattern:

#![feature(macro_rules)]

macro_rules! foo{
() => {{
macro_rules! bar{() => (())}
1
}}
}

pub fn main() {
foo!();

assert!({one! two()});

// regardless of whether nested macro_rules works, the following should at
// least throw a conventional error.
assert!({one! two});
}