Fix unsafety in StrInterner #17221
Merged
Fix unsafety in StrInterner #17221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The string slices returned by `get_ref` can actually be invalidated by calling `clear`. Since this method is unused, it is easiest to simply remove it. Closes #17181
bkoropoff
force-pushed
the
strinterner-unsafe
branch
from
7c74f4a to
26d716a
Compare
|
cc @sfackler |
bors
added a commit
that referenced
this pull request
Sep 15, 2014
The `StrInterner::clear()` method takes self immutably but can invalidate references returned by `StrInterner::get_ref`. Since `get_ref` is unused, just remove it. Closes #17181
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
May 19, 2024
internal: Lazier macro parse tree validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
StrInterner::clear()method takes self immutably but can invalidate references returned byStrInterner::get_ref. Sinceget_refis unused, just remove it.Closes #17181