Fix a race condition between remove_from_env and other io::process tests. #17739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aha, that would indeed cause the flakiness we're seeing, nice find! Can you move this test to a |
eddyb
force-pushed
the
fix-process-test
branch
from
e0a690f to
ef69388
Compare
eddyb
changed the title
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Oct 3, 2014
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Aug 1, 2024
minor: Set tracing level to debug when `cargo config get env` fails fixes rust-lang#17739
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.