Proper static lib packaging #18739
Merged
Proper static lib packaging #18739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A couple of comments - I've decided not to remove extra file name as it might complicate the code: if user asks to keep temp files and/or asks to emit |
|
@alexcrichton any idea why PR still isn't marked as approved in bors queue? |
|
Good old github! I placed the "r+" on the rust-lang/rust commit instead of the vhbit/rust commit (yay clicking links) |
bors
added a commit
that referenced
this pull request
Nov 9, 2014
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Dec 23, 2024
fix: Don't trigger paren wrapping typing handler after idents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18574