Remove perl as a dependency #21242
Merged
Remove perl as a dependency #21242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
Not sure what exploded here. I'll poke. |
bors
added a commit
that referenced
this pull request
Jan 21, 2015
There's only one build-critical path in which perl is used, and it was to do a text replacement trivially achievable with sed(1). I ported the indenter script because it [appears to be used][indenter], but removed check links because it appears to be entirely out of date. [indenter]: https://github.com/rust-lang/rust/blob/master/src/librustc/util/common.rs#L60-70
|
Can #12913 be closed now that this has merged? |
|
Yes! Thanks, that's a great catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's only one build-critical path in which perl is used, and it was to do a text replacement trivially achievable with sed(1).
I ported the indenter script because it appears to be used, but removed check links because it appears to be entirely out of date.