Make make tidy Python scripts more idiomatic
#21539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
|
||
| with open(path, 'r') as f: | ||
| for line_num, line in enumerate(f, start=1): | ||
| p = re.compile("(E\d\d\d\d)") |
There was a problem hiding this comment.
move the regex compile out of the for loop
There was a problem hiding this comment.
Good point; changing this now.
iKevinY
changed the title
make tidy scriptsmake tidy Python scripts more idiomatic
| # except according to those terms. | ||
| """ | ||
| license_re = re.compile( | ||
| u"""(#|//) Copyright .* The Rust Project Developers. See the COPYRIGHT |
There was a problem hiding this comment.
This should probably be a raw string literal (i.e., ur"""…"""), so all the doubled backslashes can be removed.
There was a problem hiding this comment.
I implemented it this way initially, but Python 3 didn't like it.
Also makes errorck.py and tidy.py compatible with Python 3.
|
@bors: rollup |
flaper87
added a commit
to flaper87/rust
that referenced
this pull request
Jan 23, 2015
Also makes `errorck.py` and `tidy.py` compatible with Python 3.
flaper87
added a commit
to flaper87/rust
that referenced
this pull request
Jan 24, 2015
Also makes `errorck.py` and `tidy.py` compatible with Python 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes
errorck.pyandtidy.pycompatible with Python 3.