Rollup of 11 pull requests #22842
Closed
Rollup of 11 pull requests #22842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeps the method consistent with `Iterator::any`. Closes rust-lang#22617 [breaking-change]
…iveness, but is necessary for now to work around rust-lang#22806. Fixes rust-lang#22655.
Changes .or() so that it can return a Result with a different E type
than the one it is called on.
Essentially:
fn or(self, res: Result<T, E>) -> Result<T, E>
becomes
fn or<F>(self, res: Result<T, F>) -> Result<T, F>
This brings `or` in line with the existing `and` and `or_else` member
types.
This is a
[breaking-change]
Due to some code needing additional type annotations.
which starts happening after ~2 hours of machine uptime.
The branch "else { continue }" is the last code inside a loop body,
it is just useless.
Signed-off-by: Lai Jiangshan <[email protected]>
(Regression tests are in followup commit.)
r? @steveklabnik Closes rust-lang#22698 I wasn't sure that this was appropriate for the book, but I've added this to the reference. I also noticed that one of the U+ symbols in the character literals section was missing the graves.
When warnings and errors occur, the associated help message should not print the same code snippet. rust-lang#21938
Check for unbounded recursion during dropck. Such recursion can be introduced by the erroneous use of non-regular types (aka types employing polymorphic recursion), which Rust does not support. Fix rust-lang#22443
…elix which starts happening after ~2 hours of machine uptime. Closes rust-lang#17845
Keeps the method consistent with `Iterator::any`. Closes rust-lang#22617 [breaking-change]
…ecursion, r=pnkfelix Change MarkerTrait to be invariant. This is a (small) loss of expressiveness, but is necessary for now to work around rust-lang#22806. Fixes rust-lang#22655. r? @pnkfelix
Changes .or() so that it can return a Result with a different E type
than the one it is called on.
Essentially:
fn or(self, res: Result<T, E>) -> Result<T, E>
becomes
fn or<F>(self, res: Result<T, F>) -> Result<T, F>
This brings `or` in line with the existing `and` & `or_else`
This is a
[breaking-change]
Due to some code needing additional type annotations.
Simple PR to fix some build warnings on a clean clone of master.
```
/home/ubuntu/src/rust/src/librustc/middle/astconv_util.rs:71:51: 71:53 warning: obsolete syntax: []
/home/ubuntu/src/rust/src/librustc/middle/astconv_util.rs:71 Some(prim_ty_to_ty(tcx, &path.segments[], nty))
^~
note: write `[..]` instead
...
/home/ubuntu/src/rust/src/librustc_resolve/lib.rs:2988:53: 2988:55 warning: obsolete syntax: []
/home/ubuntu/src/rust/src/librustc_resolve/lib.rs:2988 self.resolve_error(trait_path.span, &msg[]);
^~
note: write `[..]` instead
```
… r=dotdash
The branch "else { continue }" is the last code inside a loop body,
it is just useless.
Signed-off-by: Lai Jiangshan <[email protected]>
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1337 |
|
🙀 |
|
⌛ Testing commit f943de9 with merge b0ed0cd... |
|
💔 Test failed - auto-linux-64-x-android-t |
|
I don't have time to deal with this today :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo newto "Hello Cargo!" chapter. #22732, Added documentation of backslash ending string literals. #22748, Change span_help calls to fileline_help where appropriate so as not to duplicate code snippets #22764, Check for unbounded recursion during dropck #22777, Fix overflow in precise_time_ns() on Windows, #22788, std: Require&mut selffor Iterator::all #22795, Change MarkerTrait to be invariant. #22809, Result::or : avoid over-specializing the type #22817, Fix up build warnings about use of [] #22824, remove the redundant else branch #22833, Revert hacks and add test for LLVM aborts due to empty aggregates. #22837