-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Pull Request for #22721 #22845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull Request for #22721 #22845
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
Hey @mund! Everything is right here, except one detail: this can't be merged, because there are some conflicts. It seems like you also have some extra commits you didn't intend to get here, as well. If you fix up your |
I reverted back to the only commit that was supposed to get here ... I think? |
@mund you still have inapropriate commits. What you could do is an interactive Eventually force push your updated You should take a look at how to use branches and the rebase command, it will be of tremendous use for you in the long run :) |
…abnik I had to fix up some PRs: * rust-lang#22976 * rust-lang#22945 * rust-lang#22845
This landed in #23179. Thanks! |
This is my first time doing this, so not entirely sure if I'm doing it right. Please let me know if I made any blunders :)