Skip to content

Pull Request for #22721 #22845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Pull Request for #22721 #22845

wants to merge 4 commits into from

Conversation

munds
Copy link
Contributor

@munds munds commented Feb 26, 2015

This is my first time doing this, so not entirely sure if I'm doing it right. Please let me know if I made any blunders :)

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik
Copy link
Member

Hey @mund!

Everything is right here, except one detail: this can't be merged, because there are some conflicts. It seems like you also have some extra commits you didn't intend to get here, as well. If you fix up your master branch and then force push, github will update the pull request.

@alexcrichton
Copy link
Member

r? @steveklabnik

This rolls back to commit d9fe335.
@munds
Copy link
Contributor Author

munds commented Feb 27, 2015

r? @steveklabnik

I reverted back to the only commit that was supposed to get here ... I think?

@gamazeps
Copy link
Contributor

@mund you still have inapropriate commits.

What you could do is an interactive rebase, it's quite a powerfull feature of git.
Here the command you could do is (according to your fork of rust)
$ git rebase -i f0f7ca27de6 # tells git what is the last commit it should consider
There it will open a file in your default editor, simply erase the line with the commits you do not want.
You should just keep the line: Modified L1247 of src/libsyntax/ast.rs

Eventually force push your updated master branch to github.

You should take a look at how to use branches and the rebase command, it will be of tremendous use for you in the long run :)

@steveklabnik steveklabnik mentioned this pull request Mar 8, 2015
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 8, 2015
bors added a commit that referenced this pull request Mar 8, 2015
@steveklabnik
Copy link
Member

This landed in #23179. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants