Remove incorrect subtyping for &mut Trait and introduce coercion
#23515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wish you'd cc me on these. |
|
cc @eddyb :) |
| ty::mt { ty: ty, mutbl: a_mt.mutbl } | ||
| } | ||
| _ => try!(this.mts(a_mt, b_mt)) | ||
| }; |
|
r+ modulo nits |
for `&mut (Trait+'a)` to `&mut (Trait+'b)` if `'a:'b`. Fixes rust-lang#14985.
nikomatsakis
force-pushed
the
issue-14985-trait-subtyping
branch
from
0667c5e to
50ea6f6
Compare
|
⌛ Testing commit 50ea6f6 with merge 349fbc5... |
|
⛄ The build was interrupted to prioritize another pull request. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 23, 2015
…ping Remove incorrect subtyping for `&mut Trait` and introduce coercion for `&mut (Trait+'a)` to `&mut (Trait+'b)` if `'a:'b`. Fixes rust-lang#14985. r? @nrc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove incorrect subtyping for
&mut Traitand introduce coercion for&mut (Trait+'a)to&mut (Trait+'b)if'a:'b.Fixes #14985.
r? @nrc