Skip to content

Add common macros to TRPL #24516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2015
Merged

Add common macros to TRPL #24516

merged 1 commit into from
Apr 21, 2015

Conversation

steveklabnik
Copy link
Member

Fixes #22621

@rust-highfive
Copy link
Contributor

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton
alexcrichton reviewed Apr 17, 2015
View reviewed changes
src/doc/trpl/macros.md
takes two values and compares them. Truth passes, success `panic!`s. Like
this:

```rust,ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could these be tagged with no_run instead of ignore wherever possible?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@steveklabnik
Copy link
Member Author

@alexcrichton updated!

@alexcrichton
Copy link
Member

@bors: r+ b4dc187

@bors
Copy link
Collaborator

bors commented Apr 20, 2015

⌛ Testing commit b4dc187 with merge a0369bd...

tamird
tamird reviewed Apr 20, 2015
View reviewed changes
src/doc/trpl/macros.md
This macro causes the current thread to panic. You can give it a message
to panic with:

```rust,ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ignore here but no_run elsewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, this can be no_run too

@steveklabnik
Copy link
Member Author

oh, huh

@steveklabnik
Copy link
Member Author

@bors: r=alexcrichton rollup

@bors
Copy link
Collaborator

bors commented Apr 20, 2015

📌 Commit 1e29abe has been approved by alexcrichton

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 20, 2015
@steveklabnik
Rollup merge of rust-lang#24516 - steveklabnik:gh22621, r=alexcrichton
09a0834 
Fixes rust-lang#22621
@steveklabnik steveklabnik mentioned this pull request Apr 20, 2015
Closed
bors added a commit that referenced this pull request Apr 20, 2015
@bors
Auto merge of #24637 - steveklabnik:rollup, r=steveklabnik
064a677 
- Successful merges: #24516, #24537, #24571, #24577, #24625, #24627, #24628, #24629, #24630, #24632
- Failed merges:
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 21, 2015
@steveklabnik
Rollup merge of rust-lang#24516 - steveklabnik:gh22621, r=alexcrichton
de13f95 
Fixes rust-lang#22621
@steveklabnik steveklabnik mentioned this pull request Apr 21, 2015
Merged
bors added a commit that referenced this pull request Apr 21, 2015
@bors
Auto merge of #24648 - steveklabnik:rollup, r=steveklabnik
21c48c3 
- Successful merges: #24514, #24516, #24571, #24577, #24625, #24627, #24628, #24629, #24630, #24631, #24632, #24642, #24643, #24647
- Failed merges: #24640
@bors bors merged commit 1e29abe into rust-lang:master Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate docs for built-in syntax extensions
6 participants
@steveklabnik @rust-highfive @alexcrichton @bors @tamird @pcwalton