Skip to content

std::rand::os: Fix race condition of atomics #24526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2015

Conversation

klutzy
Copy link
Contributor

@klutzy klutzy commented Apr 17, 2015

Fixes #21538.

@rust-highfive
Copy link
Contributor

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Could this use a Once? That seems more idiomatic and error-prone as well.

@klutzy
Copy link
Contributor Author

klutzy commented Apr 19, 2015

done!

@alexcrichton
Copy link
Member

@bors: r+ 4d80a82

@bors
Copy link
Collaborator

bors commented Apr 19, 2015

⌛ Testing commit 4d80a82 with merge 5228bcc...

@bors
Copy link
Collaborator

bors commented Apr 19, 2015

💔 Test failed - auto-linux-32-opt

@alexcrichton
Copy link
Member

@bors: retry

On Sun, Apr 19, 2015 at 4:13 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-linux-32-opt
http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/4584


Reply to this email directly or view it on GitHub
#24526 (comment).

bors added a commit that referenced this pull request Apr 19, 2015
@bors
Copy link
Collaborator

bors commented Apr 19, 2015

⌛ Testing commit 4d80a82 with merge c6b8d96...

@bors
Copy link
Collaborator

bors commented Apr 19, 2015

@bors bors merged commit 4d80a82 into rust-lang:master Apr 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

std::os::rand::imp::is_getrandom_available atomics use is racy
5 participants