Lint non-snake-case crate names #24592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
| if let Some(ref name) = cx.tcx.sess.opts.crate_name { | ||
| self.check_snake_case(cx, "crate", name, None); | ||
| } else if let Some(ref name) = attr_crate_name { | ||
| self.check_snake_case(cx, "crate", name, None); |
There was a problem hiding this comment.
In this branch we have an attribute, so perhaps the span of the attribute could be passed?
|
Thanks! |
Passing a non-snake-case name to #![crate_name] or --crate-name will now yield a warning from the `non_snake_case` lint.
ftxqxd
force-pushed
the
style-lints-changes
branch
from
f284843 to
c163f89
Compare
|
OK, it now shows the error on the attribute’s span if one exists. |
bors
added a commit
that referenced
this pull request
Apr 19, 2015
Passing a non-snake-case name to `#![crate_name]` or `--crate-name` will now yield a warning from the `non_snake_case` lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a non-snake-case name to
#![crate_name]or--crate-namewill now yield a warning from thenon_snake_caselint.