Skip to content

std: Don't use a wrapper for the float error type #24792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2015

Conversation

alexcrichton
Copy link
Member

Ensures that the same error type is propagated throughout. Unnecessary leakage
of the internals is prevented through the usage of stability attributes.

Closes #24748

@rust-highfive
Copy link
Contributor

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@aturon
Copy link
Member

aturon commented May 1, 2015

I am going to hold my nose and r+ this. Just points to the lack of crate-level privacy, amongst other things.

@bors: r+

@bors
Copy link
Collaborator

bors commented May 1, 2015

📌 Commit 95f1db3 has been approved by aturon

@bors
Copy link
Collaborator

bors commented May 1, 2015

⌛ Testing commit 95f1db3 with merge be91c0a...

@bors
Copy link
Collaborator

bors commented May 1, 2015

💔 Test failed - auto-mac-64-nopt-t

Ensures that the same error type is propagated throughout. Unnecessary leakage
of the internals is prevented through the usage of stability attributes.

Closes rust-lang#24748
@alexcrichton
Copy link
Member Author

@bors: r+ 1291041

@bors
Copy link
Collaborator

bors commented May 2, 2015

⌛ Testing commit 1291041 with merge c42c1e7...

bors added a commit that referenced this pull request May 2, 2015
Ensures that the same error type is propagated throughout. Unnecessary leakage
of the internals is prevented through the usage of stability attributes.

Closes #24748
@bors bors merged commit 1291041 into rust-lang:master May 2, 2015
@alexcrichton alexcrichton deleted the issue-24748 branch May 5, 2015 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

std::num::ParseFloatError != <f64 as FromStr>::Err
5 participants