Skip to content

IMO better borrow_mut() documentation on RefCell #24849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2015
Merged

Conversation

gareins
Copy link
Contributor

@gareins gareins commented Apr 26, 2015

Previous borrow() is enough to make borrow_mut() panic, no need to have borrow_mut() twice. This

Previous borrow() is enough to make borrow_mut() panic, no need to have borrow_mut() twice. [This](http://is.gd/woKKAW)
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 26, 2015

📌 Commit de35823 has been approved by steveklabnik

@steveklabnik
Copy link
Member

Thanks so much!

@bors
Copy link
Collaborator

bors commented Apr 27, 2015

⌛ Testing commit de35823 with merge f4ab2b3...

bors added a commit that referenced this pull request Apr 27, 2015
Previous borrow() is enough to make borrow_mut() panic, no need to have borrow_mut() twice. [This](http://is.gd/woKKAW)
@bors
Copy link
Collaborator

bors commented Apr 27, 2015

💔 Test failed - auto-linux-32-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

On Sun, Apr 26, 2015 at 10:55 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-linux-32-nopt-t
http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/4696


Reply to this email directly or view it on GitHub
#24849 (comment).

@bors
Copy link
Collaborator

bors commented Apr 27, 2015

@bors bors merged commit de35823 into rust-lang:master Apr 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants