-
Notifications
You must be signed in to change notification settings - Fork 13.3k
IMO better borrow_mut() documentation on RefCell #24849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Previous borrow() is enough to make borrow_mut() panic, no need to have borrow_mut() twice. [This](http://is.gd/woKKAW)
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
@bors: r+ rollup |
📌 Commit de35823 has been approved by |
Thanks so much! |
⌛ Testing commit de35823 with merge f4ab2b3... |
Previous borrow() is enough to make borrow_mut() panic, no need to have borrow_mut() twice. [This](http://is.gd/woKKAW)
💔 Test failed - auto-linux-32-nopt-t |
@bors: retry On Sun, Apr 26, 2015 at 10:55 PM, bors [email protected] wrote:
|
⚡ Previous build results for auto-linux-64-nopt-t, auto-mac-32-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt... |
Previous borrow() is enough to make borrow_mut() panic, no need to have borrow_mut() twice. This