Skip to content

Improve std::vec module documentation. #25087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2015
Merged

Conversation

nham
Copy link
Contributor

@nham nham commented May 4, 2015

This commit does two things: it adds an example for indexing vectors, and it changes the "Examples" section to use full sentences.

This change was spurred by someone in the #rust IRC channel asking if there was a .set() method for changing the i-th value of a vector (they had missed that Vec implements IndexMut, which is easy to do if you're not aware of that trait).

This changes the std::vec module docs to use full sentences. It also adds an example
for indexing vectors.
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@Gankra
Copy link
Contributor

Gankra commented May 4, 2015

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 4, 2015

📌 Commit 51463c3 has been approved by Gankro

@bors
Copy link
Collaborator

bors commented May 4, 2015

⌛ Testing commit 51463c3 with merge abb67f6...

@bors
Copy link
Collaborator

bors commented May 4, 2015

💔 Test failed - auto-win-64-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

On Mon, May 4, 2015 at 9:46 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/3294


Reply to this email directly or view it on GitHub
#25087 (comment).

Manishearth added a commit to Manishearth/rust that referenced this pull request May 5, 2015
 This commit does two things: it adds an example for indexing vectors, and it changes the \"Examples\" section to use full sentences.

This change was spurred by someone in the #rust IRC channel asking if there was a `.set()` method for changing the `i`-th value of a vector (they had missed that `Vec` implements `IndexMut`, which is easy to do if you're not aware of that trait).
@bors bors merged commit 51463c3 into rust-lang:master May 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants