Skip to content

Change rand version to '*' #25179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2015
Merged

Change rand version to '*' #25179

merged 3 commits into from
May 8, 2015

Conversation

bengesoff
Copy link
Contributor

Following paragraph says "we've used * which..." but code says "rand="0.3.0""

Following paragraph says "we've used `*` which..." but code says "rand=\"0.3.0\""
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik
Copy link
Member

Nice catch @bengesoff ! Unfortunately, this was my mistake: at the last minute, I changed it to 0.3.0, which is better in this case. I'd rather upgrade the paragraph to talk about 0.3.0. Would you mind changing this PR to do that instead?

changed paragraphs with discussion of Cargo.lock file to agree with rand version 0.3.0 in the Cargo.tom file.
@bengesoff
Copy link
Contributor Author

Quite a lot of refactoring to do given that Cargo.lock and versioning was discussed in detail later on!

Downloading libc v0.1.6
Compiling libc v0.1.6
Compiling rand v0.3.8
Compiling rand v0.3.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two sets shouldn't change, actually... more below

@steveklabnik
Copy link
Member

Sorry for the extra nits, I should have mentioned it upfront :(

When you specify 0.3.0, it is short for ^0.3.0. So, we'll still get 0.3.8 today. does that make sense?

@huonw
Copy link
Member

huonw commented May 7, 2015

A version specifier 0.3.0 is actually satisfied by 0.3.x for any x, in particular cargo will take the latest release in the 0.3 series, so it will still be using 0.3.8.

(I personally just write, e.g. rand = "0.3" and skip specifying the minor version usually.)

Didn't realise 0.3.0 referred to all 0.3.x versions! Fixed my mistakes. Should have just updated the Cargo.toml now.
@bengesoff
Copy link
Contributor Author

Thank you for clarifying - I have learnt something new 😊

@steveklabnik
Copy link
Member

🎊

@steveklabnik
Copy link
Member

(Also, the reason that it was inconsistent was because I too learned something new, haha!)

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented May 7, 2015

📌 Commit 888086d has been approved by steveklabnik

@steveklabnik
Copy link
Member

Thanks so much again for this patch!

@bengesoff
Copy link
Contributor Author

No problem!

@tshepang
Copy link
Member

tshepang commented May 7, 2015

would be nice if the commits were squashed

Manishearth added a commit to Manishearth/rust that referenced this pull request May 8, 2015
Following paragraph says "we've used `*` which..." but code says "rand=\"0.3.0\""
Manishearth added a commit to Manishearth/rust that referenced this pull request May 8, 2015
Following paragraph says "we've used `*` which..." but code says "rand=\"0.3.0\""
bors added a commit that referenced this pull request May 8, 2015
@bors bors merged commit 888086d into rust-lang:master May 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants