-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Change rand version to '*' #25179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change rand version to '*' #25179
Conversation
Following paragraph says "we've used `*` which..." but code says "rand=\"0.3.0\""
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
Nice catch @bengesoff ! Unfortunately, this was my mistake: at the last minute, I changed it to |
changed paragraphs with discussion of Cargo.lock file to agree with rand version 0.3.0 in the Cargo.tom file.
Quite a lot of refactoring to do given that Cargo.lock and versioning was discussed in detail later on! |
Downloading libc v0.1.6 | ||
Compiling libc v0.1.6 | ||
Compiling rand v0.3.8 | ||
Compiling rand v0.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these two sets shouldn't change, actually... more below
Sorry for the extra nits, I should have mentioned it upfront :( When you specify |
A version specifier (I personally just write, e.g. |
Didn't realise 0.3.0 referred to all 0.3.x versions! Fixed my mistakes. Should have just updated the Cargo.toml now.
Thank you for clarifying - I have learnt something new 😊 |
🎊 |
(Also, the reason that it was inconsistent was because I too learned something new, haha!) |
@bors: r+ rollup |
📌 Commit 888086d has been approved by |
Thanks so much again for this patch! |
No problem! |
would be nice if the commits were squashed |
Following paragraph says "we've used `*` which..." but code says "rand=\"0.3.0\""
Following paragraph says "we've used `*` which..." but code says "rand=\"0.3.0\""
Following paragraph says "we've used
*
which..." but code says "rand="0.3.0""