Skip to content

No more tasks #25216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2015
Merged

No more tasks #25216

merged 4 commits into from
May 9, 2015

Conversation

barosl
Copy link
Contributor

@barosl barosl commented May 8, 2015

I've found that there are still huge amounts of occurrences of tasks in the documentation. This PR tries to eliminate all of them in favor of thread.

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@barosl barosl changed the title No more task No more tasks May 8, 2015
@alexcrichton
Copy link
Member

@bors: r+ 2cae138 rollup

Thanks!

@bors
Copy link
Collaborator

bors commented May 8, 2015

☔ The latest upstream changes (presumably #25136) made this pull request unmergeable. Please resolve the merge conflicts.

barosl added 3 commits May 9, 2015 02:24
An automated script was run against the `.rs` and `.md` files,
subsituting every occurrence of `task` with `thread`. In the `.rs`
files, only the texts in the comment blocks were affected.
@Manishearth
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented May 8, 2015

📌 Commit 9b91ccf has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented May 9, 2015

⌛ Testing commit 9b91ccf with merge 0ae651f...

Manishearth added a commit to Manishearth/rust that referenced this pull request May 9, 2015
I've found that there are still huge amounts of occurrences of `task`s in the documentation. This PR tries to eliminate all of them in favor of `thread`.
@bors
Copy link
Collaborator

bors commented May 9, 2015

⛄ The build was interrupted to prioritize another pull request.

bors added a commit that referenced this pull request May 9, 2015
@bors bors merged commit 9b91ccf into rust-lang:master May 9, 2015
@steveklabnik
Copy link
Member

@barosl do you have interest in getting this into 1.0? It's fairly complex, but if you're willing to do the backport, I'm willing to add it in.

@barosl
Copy link
Contributor Author

barosl commented May 11, 2015

@steveklabnik Sure, what should I do for it? Should I create a PR against the beta branch?

I still have the conversion script, so the substitution itself won't be that hard.

@steveklabnik
Copy link
Member

Yeah make a PR against the beta branch and r? me :)

Sent from my iPhone

On May 10, 2015, at 21:33, Barosl Lee [email protected] wrote:

@steveklabnik Sure, what should I do for it? Should I create a PR against the beta branch?

I still have the conversion script, so the substitution itself won't be that hard.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants