Rollup of 10 pull requests #25281
Merged
Rollup of 10 pull requests #25281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
May 10, 2015
steveklabnik
commented
- Successful merges: link to .editorconfig for Rust files #24948, Add #[inline(always)] to various instances of AsRef::as_ref and AsMut::as_mut #25158, Typo in ownership.md #25188, Add a precision for references issues in doc #25222, Fixed a typo. Removed an extra s. #25239, Add example for HashMap::entry() #25240, Added start of last text block #25241, Add a few diagnostic messages #25255, Trivial documentation changes in Mutability, Match #25257, Fix small typos in documentation #25263
- Failed merges:
I've written a small [EditorConfig](http://editorconfig.org) file for Rust development.
PR rust-lang#24611 added these for other architectures, but missed the `#[cfg(any(target_arch = "mips", target_arch = "mipsel"))]` version of the module. The values are the same.
This is a fork of the flt2dec portion of rust-strconv [1] with a necessary relicensing (the original code was licensed CC0-1.0). Each module is accompanied with large unit tests, integrated in this commit as coretest::num::flt2dec. This module is added in order to replace the existing core::fmt::float method. The forked revision of rust-strconv is from 2015-04-20, with a commit ID 9adf6d3571c6764a6f240a740c823024f70dc1c7. [1] https://github.com/lifthrasiir/rust-strconv/
As a side effect `core::fmt::float` is gone now. This also slightly changes the float output, so this is: [breaking-change]
The bug involves the incorrect logic for `core::num::flt2dec::decoder`. This makes some numbers in the form of 2^n missing one final digits, which breaks the bijectivity criterion. The regression tests have been added, and f32 exhaustive test is rerun to get the updated result.
The master no longer has `std::num::Float`, so a generic `ldexp` is not readily available. `DecodableFloat::ldexpi` works around this.
For the shortest mode the IEEE 754 decoder already provides an exact rounding range accounting for banker's rounding, but it was not the case for the exact mode. This commit alters the exact mode algorithm for Dragon so that any number ending at `...x5000...` with even `x` and infinite zeroes will round to `...x` instead of `...(x+1)` as it was. Grisu is not affected by this change because this halfway case always results in the failure for Grisu.
Following paragraph says "we've used `*` which..." but code says "rand=\"0.3.0\""
changed paragraphs with discussion of Cargo.lock file to agree with rand version 0.3.0 in the Cargo.tom file.
Didn't realise 0.3.0 referred to all 0.3.x versions! Fixed my mistakes. Should have just updated the Cargo.toml now.
10.10 is out, so it's weird to see a message that says you're on 10.9. Change the message to be >=10.9.
Remove an rogue 'is' and fix some line wrapping.
…hearth In my opinion this looks nicer, but also it matches the whitespace generally used for stability markers.
… r=alexcrichton Fixes the problem in rust-lang#16974 with unhelpful error messages when accidentally using the wrong syntax for the `crate_type="lib"` attribute. The attribute syntax error now shows up instead of "main function not found".
- Successful merges: rust-lang#25200, rust-lang#25242, rust-lang#25248, rust-lang#25249, rust-lang#25251, rust-lang#25252, rust-lang#25261 - Failed merges: rust-lang#25255
I've written a small [EditorConfig](http://editorconfig.org) file for Rust development.
I was profiling my code again and this time AsRef<str> for String was eating up a considerable chunk of my runtime; adding the inline annotation made the program run almost twice as fast! While I was at it I also added the annotation to other implementations of AsRef as well as AsMut.
…bnik Add example for HashMap::entry()
The start of the last text block in references was missing, I added it. r? @steveklabnik
…richton Add a few diagnostic messages; part of rust-lang#24407.
…eklabnik I think there's a trivial missing word in the Mutability document. I reformatted the resulting paragraph in vim, which seems to match what the rest of the document is doing as far as word wrapping. Edit: I found another minor thing as I continued reading. P.S. I'm re-reading the docs, since so much has changed since my first read, and they've gotten even better! Nice job! r? @steveklabnik
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 force |
|
📌 Commit c70458b has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.