TRPL: embedding rust #25341
Merged
TRPL: embedding rust #25341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
This is based off of work by both @alexcrichton and @callahad. ❤️ |
|
|
||
| The second is related to `x` versus `_x`. Because we never actually _do_ | ||
| anything with `x`, we get a warning about it. In our case, that’s perfectly | ||
| okay, as we’re just trying to waste CPU cycles. Prefixing `x` with the |
There was a problem hiding this comment.
Unless optimiser optimises this away?
There was a problem hiding this comment.
Yeah, I had to be careful to use a debug build of my "spin uselessly" library, lest nothing happened at all. :)
There was a problem hiding this comment.
I added a let _ = x line, and performance didn't seem to change. is the optimizer smart enough in these cases?
|
Added python and node. So easy! |
| }).collect(); | ||
|
|
||
| for h in handles { | ||
| h.join().ok().expect(“Could not join a thread!”); |
steveklabnik
force-pushed
the
trpl_embedding
branch
from
3edc917 to
14e9abb
Compare
|
more nits addressed. r? @alexcrichton |
|
|
||
| That `libembed.so` is our ‘shared object’ library. We can use this file | ||
| just like any shared object library written in C! As an aside, this may be | ||
| `libembed.dll` or `libembed.dylib`, depending on the platform. |
|
Just a few minor nits here and there, but otherwise r=me, thanks @steveklabnik! |
steveklabnik
force-pushed
the
trpl_embedding
branch
from
14e9abb to
fc6372e
Compare
|
@bors: r=alexcrichton rollup |
|
📌 Commit fc6372e has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first chunk of the last guide I'll land before 1.0. I wanted to kick off reviews earlier rahter than later, so here's the important parts, with the Python and Node implementations coming later today.