Skip to content

Fix ICE trying to pass DST to C functions #25653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2015
Merged

Fix ICE trying to pass DST to C functions #25653

merged 1 commit into from
May 23, 2015

Conversation

dotdash
Copy link
Contributor

@dotdash dotdash commented May 20, 2015

Fixes #25581

@rust-highfive
Copy link
Contributor

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@arielb1
Copy link
Contributor

arielb1 commented May 20, 2015

Shouldn't you test that passing slices actually works?

@dotdash
Copy link
Contributor Author

dotdash commented May 21, 2015

Turned the test into a run-make test that actually calls C functions taking a slice.

@luqmana
Copy link
Member

luqmana commented May 22, 2015

@bors: r+

@bors
Copy link
Collaborator

bors commented May 22, 2015

📌 Commit a3c4ce4 has been approved by luqmana

Manishearth added a commit to Manishearth/rust that referenced this pull request May 22, 2015
@Manishearth
Rollup merge of rust-lang#25653 - dotdash:unsize_c, r=luqmana
9441c81 
Fixes rust-lang#25581
@Manishearth Manishearth mentioned this pull request May 22, 2015
Closed
oli-obk pushed a commit to oli-obk/rust that referenced this pull request May 23, 2015
Rollup merge of rust-lang#25653 - dotdash:unsize_c, r=luqmana
8f2c0dd 
Fixes rust-lang#25581
@oli-obk oli-obk mentioned this pull request May 23, 2015
Closed
bors added a commit that referenced this pull request May 23, 2015
@bors
Auto merge of #25653 - dotdash:unsize_c, r=luqmana
88e6976 
Fixes #25581
@bors
Copy link
Collaborator

bors commented May 23, 2015

⌛ Testing commit a3c4ce4 with merge 88e6976...

@bors
Copy link
Collaborator

bors commented May 23, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt

@bors bors merged commit a3c4ce4 into rust-lang:master May 23, 2015
@bors bors mentioned this pull request May 23, 2015
Closed
@dotdash dotdash deleted the unsize_c branch July 27, 2015 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@huonw huonw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE in LLVM innards when calling an extern fn with a slice
6 participants
@dotdash @rust-highfive @arielb1 @luqmana @bors @huonw