Skip to content

crate libc: Correct signature of WriteFile #25985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2015
Merged

Conversation

bombless
Copy link
Contributor

@bombless bombless commented Jun 3, 2015

nNumberOfBytesToRead --> nNumberOfBytesToWrite
lpNumberOfBytesRead --> lpNumberOfBytesWritten
LPVOID --> LPCVOID

See https://msdn.microsoft.com/en-us/library/windows/desktop/aa365747(v=vs.85).aspx

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Can you squash the commits together and make the commit message more descriptive as well? It's useful when browsing through the commit history to have a little more information than "Fix typo"

@bombless bombless changed the title Fix typo crate libc: Correct signature of WriteFile Jun 4, 2015
@bombless
Copy link
Contributor Author

bombless commented Jun 4, 2015

(done)
I'll be more careful next time, sorry :p

@alexcrichton
Copy link
Member

@bors: r+ dc15a52

Thanks!

bors added a commit that referenced this pull request Jun 4, 2015
nNumberOfBytesToRead --> nNumberOfBytesToWrite
lpNumberOfBytesRead --> lpNumberOfBytesWritten
LPVOID --> LPCVOID

See <https://msdn.microsoft.com/en-us/library/windows/desktop/aa365747(v=vs.85).aspx>
@bors
Copy link
Collaborator

bors commented Jun 4, 2015

⌛ Testing commit dc15a52 with merge 20cf4cf...

@bors bors merged commit dc15a52 into rust-lang:master Jun 4, 2015
@bombless bombless deleted the patch-2 branch June 5, 2015 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants