Use more precise span when checking type definitions #26221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| scope: ast::NodeId, | ||
| cache: Option<&'cx mut HashSet<Ty<'tcx>>>) | ||
| -> BoundsChecker<'cx,'tcx> { | ||
| BoundsChecker { fcx: fcx, span: span, scope: scope, | ||
| BoundsChecker { fcx: fcx, span: DUMMY_SP, scope: scope, |
There was a problem hiding this comment.
If this span field is never used, can it be deleted? If it is used, it seems odd to use DUMMY_SP here?
There was a problem hiding this comment.
After the patch, it is used, but not initialized here.
|
r? @nikomatsakis or @pnkfelix |
|
@bors r+ |
|
📌 Commit 412977d has been approved by |
|
☔ The latest upstream changes (presumably #26190) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Needs a rebase. |
|
Actually, thinking about it, I would also want tests that this feature works on both structs and enums, both tuple-like and dictionary-like. |
|
🔒 Merge conflict |
|
Rebased and added tests. |
bors
added a commit
that referenced
this pull request
Jun 12, 2015
When checking field types of struct or enum definitions, use spans for field types instead of the entire item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking field types of struct or enum definitions, use spans for field types instead of the entire item.