-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Expand a bit on thread::park spurious wakeups #26856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
I feel like this doesn't quite reflect the discussion in #26475, but after re-reading the module documentation I'm not actually sure what clarification is needed. @aidanhs could you weigh in with what you'd like to see? |
The thing missing for me was an explanation of what this library feature brings to the table - the rest of the page talks about things impossible to achieve without library support, whereas this is effectively an optimisation of a busy-wait loop (I can't think of any other uses off-hand). Some tweaked docs:
and
|
I incorporated your suggestions, @aidanhs . Improving the module documentation makes sense too, but I'll take care of that when i run through all of |
Fixes #26475 I'm not sure this is enough, really, but I'm not totally clear on what specific information would be valuable here. In the original issue, the Java page was pretty decent, but now I can't think of a different way to word it, and copying their prose is of course not acceptable. thoughts @alexcrichton @aturon @aidanhs ?
Fixes #26475
I'm not sure this is enough, really, but I'm not totally clear on what specific information would be valuable here. In the original issue, the Java page was pretty decent, but now I can't think of a different way to word it, and copying their prose is of course not acceptable.
thoughts @alexcrichton @aturon @aidanhs ?