Skip to content

Change std::fs::File.set_len example #26972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2015
Merged

Conversation

jethrogb
Copy link
Contributor

The File object needs to be writable for the set_len to succeed.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@bluss
Copy link
Member

bluss commented Jul 11, 2015

Maybe it's best to even say in the doc that the file must be writable or have the appropriate permissions. Not sure how to word it so that it's correct for Windows.

@jethrogb
Copy link
Contributor Author

MSDN is not quite clear on what permission exactly is needed, but I assume GENERIC_WRITE is ok, so we can just say 'writeable' or 'opened for writing'.

https://msdn.microsoft.com/en-us/library/windows/desktop/aa365539%28v=vs.85%29.aspx
https://msdn.microsoft.com/en-us/library/windows/desktop/aa364224%28v=vs.85%29.aspx

@alexcrichton
Copy link
Member

Thanks @jethrogb! I agree with @bluss that it'd be nice to have a clause in the documentation which suggests that this works best if the file is opened for writing as well.

The File object needs to be writable for the truncate to succeed.
@jethrogb
Copy link
Contributor Author

Done.

@alexcrichton
Copy link
Member

@bors: r+ 9262d64

Thanks!

@bors
Copy link
Collaborator

bors commented Jul 12, 2015

⌛ Testing commit 9262d64 with merge 78547d2...

bors added a commit that referenced this pull request Jul 12, 2015
The File object needs to be writable for the set_len to succeed.
@bors bors merged commit 9262d64 into rust-lang:master Jul 12, 2015
@jethrogb jethrogb deleted the patch-1 branch July 12, 2015 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants