2nd to 3rd person

[Dangthrimble]

Replacing all references to the 2nd person with references to the 3rd person (excluding authors = [ "Your name <[email protected]>" ] and file:///home/yourname/projects/hello_world in hello-cargo.md). Have to confess there are a few instances that don't feel quite right so would appreciate your views on the endeavour!

r? @steveklabnik

[steveklabnik]

So, while I'm generally super in favor of moving EVERYTHING to 'we', I think that this section should stay as-is. In this case, we are addressing the reader directly, they're the one making this choice. I think from here and above, 'you' is fine.

[steveklabnik]

This diff is awesome, thanks so much! Yeah, after reading over the literal changes, I'm with you: some feel strange. I think the ones that are specifically directed at a reader should stay 'you', imagine it's a conversation, just because you say 'we' for most things doesn't mean 'you' is always inappropriate.

Are there any that seemed off that I missed?

[steveklabnik]

Hey @Dangthrimble ! it doens't notify me when you push commits, so sorry that i missed this. I think this is good to go, can you please rebase and sqaush? r=me after 👍

[Dangthrimble]

Rebase and squash? Don't understand!

Do I need to "r=" after every update? Do you mean "r?" or does "r=" specify who it is intended for whereas "r?" indicates a preference?

I'll get the hang of GitHub one of these days!

[steveklabnik]

Whoops, sorry! :)

"Rebase and squash" is a git term: http://blog.steveklabnik.com/posts/2012-11-08-how-to-squash-commits-in-a-github-pull-request

"r=me" is a Mozilla social convention that says, "Hey anyone else with commit privileges: I'm okay with this PR, but there's one or two tiny things that still need to be fixed. If the submitter fixes them before I get back, go ahead and approve this PR."

[steveklabnik]

@Dangthrimble i see you pushed some more commits, but they still need to be squashed. Let me know after you push things, I only get a notification on comments, not on new commits :/

[Dangthrimble]

Just trying to find some spare time!

On 9 Sep 2015, at 22:10, Steve Klabnik [email protected] wrote:

@Dangthrimble i see you pushed some more commits, but they still need to be squashed. Let me know after you push things, I only get a notification on comments, not on new commits :/

—
Reply to this email directly or view it on GitHub.

[steveklabnik]

No worries! Just wanted to make sure I knew so we could get it in :)

[Dangthrimble]

Finally found some time to have a go at this but the git command line
is all gibberish to me! Till now I have done just about all by
"gitting"  using GitHub Desktop. Following the commands in your link,
how do I find out what to type in place of upstream and omgpull?
Thanks

----- Original Message -----
From: "rust-lang/rust"
To:"rust-lang/rust"
Cc:"Jonathan Hansford"
Sent:Tue, 25 Aug 2015 06:48:04 -0700
Subject:Re: [rust] 2nd to 3rd person (#27813)

Whoops, sorry! :) 

"Rebase and squash" is a git term:

http://blog.steveklabnik.com/posts/2012-11-08-how-to-squash-commits-in-a-github-pull-request
[1]

"r=me" is a Mozilla social convention that says, "Hey anyone else

with commit privileges: I'm okay with this PR, but there's one or two
tiny things that still need to be fixed. If the submitter fixes them
before I get back, go ahead and approve this PR."

—

Reply to this email directly or view it on GitHub [2].

Links:

[1]
http://blog.steveklabnik.com/posts/2012-11-08-how-to-squash-commits-in-a-github-pull-request
[2]
#27813 (comment)

[Dangthrimble]

Just found an earlier email of yours that used "git remote -v" to
identify them. I get:

 > git remote -vorigin  https://github.com/Dangthrimble/rust.git
(fetch)origin  https://github.com/Dangthrimble/rust.git
(push)rust-lang       https://github.com/rust-lang/rust.git
(fetch)rust-lang       https://github.com/rust-lang/rust.git (push)

So I guess I would:

$ git fetch rust-lang
$ git checkout origin
$ git rebase -i rust-lang/master
$ git push origin origin -f

Does that look right?

----- Original Message -----
From: "Jonathan Hansford"
To:"rust-lang/rust"
Cc:
Sent:Thu, 17 Sep 2015 12:46:53 +0100
Subject:Re: [rust] 2nd to 3rd person (#27813)

Finally found some time to have a go at this but the git command line
is all gibberish to me! Till now I have done just about all by
"gitting"  using GitHub Desktop. Following the commands in your link,
how do I find out what to type in place of upstream and omgpull?
Thanks

----- Original Message -----
From: "rust-lang/rust"
To:"rust-lang/rust"
Cc:"Jonathan Hansford"
Sent:Tue, 25 Aug 2015 06:48:04 -0700
Subject:Re: [rust] 2nd to 3rd person (#27813)

Whoops, sorry! :) 

"Rebase and squash" is a git term:

http://blog.steveklabnik.com/posts/2012-11-08-how-to-squash-commits-in-a-github-pull-request
[1]

"r=me" is a Mozilla social convention that says, "Hey anyone else

with commit privileges: I'm okay with this PR, but there's one or two
tiny things that still need to be fixed. If the submitter fixes them
before I get back, go ahead and approve this PR."

—

Reply to this email directly or view it on GitHub [2].

Links:

[1]
http://blog.steveklabnik.com/posts/2012-11-08-how-to-squash-commits-in-a-github-pull-request
[2]
#27813 (comment)

[steveklabnik]

That's right except you want to check out master. You check out the branch, not remote, and the branch of this PR is master:

[Dangthrimble]

I'm getting:

> git fetch rust-lang
> git checkout master
Already on 'master'
Your branch is ahead of 'origin/master' by 391 commits.
  (use "git push" to publish your local commits)

Those 391 commits worry me! Has something gone wrong or do I just go ahead?

[steveklabnik]

Well, that does make some sense, as we've put in a lot of development since this was opened :)

Regardless though, I've pulled in and rebased it myself: master...steveklabnik:Dangthrimble so don't worry about screwing something up, we can always fix it.

[steveklabnik]

(and if you get the chance, maybe jumping into IRC is easier than comments in this PR thread)

[bors]

☔ The latest upstream changes (presumably #28817) made this pull request unmergeable. Please resolve the merge conflicts.

[steveklabnik]

@Dangthrimble would you like me to do this rebase myself so we can get this shipped, or are you going to have time soon?

[Dangthrimble]

I'm trying to help organise my daughter's wedding at the moment and I'm 225% loaded at work for the next few months, so spare time is proving elusive! Could you do it and I'll try and pick up sometime next year!!!

Thanks

On 9 Oct 2015, at 12:45, Steve Klabnik [email protected] wrote:

@Dangthrimble would you like me to do this rebase myself so we can get this shipped, or are you going to have time soon?

—
Reply to this email directly or view it on GitHub.

[steveklabnik]

Oh wonderful! Congrats. :)

Thank you again for the patch, i'll make sure you're still the author in git.

[steveklabnik]

superceded by #28930, thanks again!

[ketsuban]

I'm unable to connect securely to Mozilla's IRC server for some reason so I'll leave my thoughts here, even though commenting on a committed pull request feels weird.

I'm not sure this was sufficiently thought through; I think the best way to show why is to provide examples and narrate. I apologise for the resulting chunkiness.

This book will teach you about the Rust Programming Language.

Indeed, this is the goal of the book. Now let's look at the revised version of this sentence.

This book will teach us about the Rust Programming Language.

If the author needs to be taught about Rust then they probably shouldn't be writing a book on it. (My understanding is the authorial voice is something akin to “the Rust community”, speaking from a position of knowledge.)

Getting started - Set up our computer for Rust development.

Get your filthy hands off my computer! This was unobjectionable when it said “your”.

If we're concerned about the potential insecurity of using curl | sh, please keep reading and see our disclaimer below.

If the author is concerned about the potential insecurity of using curl | sh, why are they doing it? The book should be addressing the reader's fears and concerns, not the author's own.

If you're on Windows, please download the appropriate installer.

Notice this didn't get changed to “we”, changing person in mid-flow. It was consistent before, but now it jars. (Incidentally, microcomplaint about the pull request itself: “we” isn't third person, it's first person plural. Third person would be “they”.)

If we decide we don't want Rust anymore, we'll be a bit sad, but that's okay.

Now you sound like you can't make up your mind.

[steveklabnik]

Thanks @ketsuban !

I'm going to be going over all of this with the editors, so I'll mark your specific concerns, and we'll see. I think starting from consistency and then making exceptions makes for ultimately clear writing, but you're right that a few of these seem off.

[ketsuban]

Alright, thanks. ☺

[KodrAus]

@steveklabnik I would think it would make more sense to start from consistency in the target audience for each statement, rather than consistency in wording for all statements?