Avoid an extra alloca/memcpy when auto-ref'ing fat pointers #28020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto_ref() handles fat pointers just fine and unlike ref_fat_ptr() does so without creating an unnecessary copy of the pointer.
dotdash
force-pushed
the
ref_fat_ptr_be_gone
branch
from
99271c4 to
05d3696
Compare
dotdash
changed the title
|
@bors r+ Sweet! |
|
📌 Commit 05d3696 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 27, 2015
r? @eddyb -- we talked about this on IRC a while back but I only now managed to get the change done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @eddyb -- we talked about this on IRC a while back but I only now managed to get the change done.