Fill in some missing parts in the default AST and HIR visitors #28715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Add helper macro for walking lists (including Options)
| } | ||
| TyPath(ref maybe_qself, ref path) => { | ||
| if let Some(ref qself) = *maybe_qself { | ||
| for qself in maybe_qself { |
There was a problem hiding this comment.
Not sure I like this change - if let seems more appropriate than for here - why the change?
There was a problem hiding this comment.
It's just.. shorter, and doesn't have ()=*s
|
Nice! r=me without the |
|
@nrc |
|
@bors: r+ |
|
📌 Commit 4764d98 has been approved by |
bors
added a commit
that referenced
this pull request
Sep 29, 2015
Some minor parts of AST and HIR were not visited by the `visit::walk_xxx` methods - some identifiers, lifetimes, loop labels, attributes of exported macros - but nothing as serious as in, for example, #28364. \+ Added a convenience macro for visiting lists (including Options) \+ Removed some pre-Deref-coersions `&**` noise from visitors r? @nrc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor parts of AST and HIR were not visited by the
visit::walk_xxxmethods - some identifiers, lifetimes, loop labels, attributes of exported macros - but nothing as serious as in, for example, #28364.&**noise from visitorsr? @nrc