Documented caveat of the remove_dir_all #29324
Conversation
I'm not sure the wording is great. Maybe it's just a bug that is going to be fixed because the current behavior is probably useless. But if it is, it's a backwards-incompatible change.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
This is partially result of rust-lang/rust#29324 But should be probably better fixed in future
|
I think we'd be fine actually fixing bugs like this, I would prefer to not document "obviously wrong" behavior and instead just fix the bug in question. |
|
Okay. Just submitted a butfix pull request. |
I'm not sure the wording is great.
Maybe it's just a bug that is going to be fixed because the current behavior is probably useless. But if it is, it's a backwards-incompatible change.